[duplicate-code] Duplicate Code: pull_request event detection duplicated across safe_update files #66295

Pattern: on field -> (hasPR, hasPRTarget)

• Severity: Medium
• Occurrences: 2 (exact duplicate, different files, same package)
• Locations:
  • pkg/workflow/safe_update_enforcement.go (lines 131-153, extractPullRequestEventPresenceFromOnField)
  • pkg/workflow/safe_update_manifest.go (lines 182-204, detectPullRequestEvents)
• Code Sample:

  func detectPullRequestEvents(onField any) (hasPR bool, hasPRTarget bool) {
      switch v := onField.(type) {
      case string:
          return v == "pull_request", v == "pull_request_target"
      case []any:
          for _, item := range v {
              event, ok := item.(string)
              if !ok { continue }
              if event == "pull_request" { hasPR = true }
              if event == "pull_request_target" { hasPRTarget = true }
          }
      case map[string]any:
          _, hasPR = v["pull_request"]
          _, hasPRTarget = v["pull_request_target"]
      }
      return hasPR, hasPRTarget
  }

  extractPullRequestEventPresenceFromOnField is identical except for its name.

Both live in package workflow, so one can directly call the other with no import changes. Current callers: compiler.go:639 and safe_update_enforcement.go:164 use the first; safe_update_manifest.go:131 uses the second.

• Analyzed Files: pkg/ (1435 non-test .go files)
• Detection Method: Serena semantic code analysis + function-body fingerprinting
• Commit: 3fd44f8
• Analysis Date: 2026-10-06