Skip to content

[deep-report] Replace 4 remaining production time.Sleep calls with ctx-aware waits #66257

Description

@github-actions

Description

Four production time.Sleep calls remain uninterruptible by cancellation or caller timeout, confirmed by direct read:

  • pkg/cli/run_workflow_tracking.go:73
  • pkg/cli/trial_repository.go:199
  • pkg/cli/update_extension_check.go:412
  • pkg/workflow/docker_validation.go:220 (note: source report cited this as docker_validation.go without the pkg/workflow/ prefix — confirmed actual location via find)

Expected Impact

Closes the last few time.Sleep violations the repo's own timesleepnocontext linter targets; these waits become cancellable rather than blocking for their full duration regardless of context cancellation.

Suggested Fix

Replace each with a ctx-aware wait:

select {
case <-ctx.Done():
    return ctx.Err()
case <-time.After(d):
}

Acceptance Criteria

  • No unannotated time.Sleep remains in the four listed locations
  • make test-unit passes

Suggested Agent

Go-focused agent; small, mechanical change per site.

Estimated Effort

Quick (< 1 hour).

Data Source

Repository Quality: Context Propagation & Cancellation Hygiene — 2026-10-06 (#66149), Task 4 (path corrected for docker_validation.go after verification).

Generated by 🔬 Deep Report · claude · agent · 421.8 AIC · ⌖ 9.14 AIC · ⊞ 7.1K · ◷

  • expires on Oct 8, 2026, 10:47 AM UTC-08:00

Activity

  1. github-actions commented on Oct 8, 2026

    @github-actions
    ContributorAuthor

    This issue was automatically closed because it expired on 2026-10-08T18:47:03.440Z.

    Closed by Workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions