Skip to content

[windows-integration] Improve Windows CLI integration scenario matrix coverage #65781

Description

@github-actions

Overview

The daily Windows CLI integration workflow covers many of the requested behaviors, including pwsh, Windows PowerShell, and cmd; direct and PATH-based execution; help and unknown-command paths; timeouts; ConPTY and stdin hang checks; and an always() conclusion job that opens an issue on failure.

Please tighten the scenario coverage so the declared shell × launch mode × environment shape × path style matrix exercises the combinations systematically. The current matrix lists 16 sparse cases, while several important behaviors are separate one-off checks. In particular, the “toolcache-first” fixture contains no gh-aw.exe, so it does not exercise PATH shadowing.

Requested updates

Coverage gaps and suggested checks
  • Define a systematic matrix or generated coverage plan that accounts for each supported shell, launch mode, environment shape, and path style. Record each scenario in the step summary so failures identify all four dimensions.
  • Make PATH precedence cases real: put a distinguishable gh-aw.exe fixture in the toolcache-like directory, verify which binary resolves when workspace or toolcache comes first, and retain a duplicate-entry case. Check resolution from both PowerShell families and cmd where applicable.
  • Bring path and environment variations into the scenario plan: paths with spaces and parentheses, mixed slash styles, Unicode working directories, NO_COLOR, TERM, CI, unset variables, and a minimal environment. Assert the expected color behavior for NO_COLOR as well as TERM=dumb.
  • Keep the default-profile and -NoProfile paths for pwsh and Windows PowerShell, and include cmd execution and .exe/PATHEXT resolution in the documented coverage.
  • Preserve timeouts on each launched shell and CLI process, with the timed-out command and scenario dimensions in the failure output. Keep the fast explicit unknown-command and stdin/ConPTY hang checks.

References

Generated by 🪟 Daily Windows Terminal Integration Builder · codex · gpt60 · 48.3 AIC · ⌖ 26.6 AIC · ⊞ 15K · ◷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions