Skip to content

Consider removing "*.thing text" from lots of .gitattributes files?聽#190

Description

@jcbhmr

Bottom line: Why is it there? Isn't *.thing text the normal default? 馃

image

https://www.git-scm.com/docs/gitattributes

It would appear from my limited understanding that leaving it unset for these *.json and other text-like files is best so that it respects the user's preference of core.autocrlf, right? Sorta like how most .gitignore templates do not include .DS_Store in them and expect a global ~/.gitignore to take care of that.

examples of this where I think it should be reconsidered:

https://github.com/alexkaratarakis/gitattributes/blob/2dfb1d9df6e22790881048871019ac8cf7a76011/Perl.gitattributes#L5-L6

https://github.com/alexkaratarakis/gitattributes/blob/2dfb1d9df6e22790881048871019ac8cf7a76011/Fortran.gitattributes#L6-L10

https://github.com/alexkaratarakis/gitattributes/blob/2dfb1d9df6e22790881048871019ac8cf7a76011/Ballerina.gitattributes#L9-L24

(those were all just found randomly clicking on the sidebar lmao)

idk

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions