TST: adapt colorbar tests to changes in matplotlib master #1962

Activity

1. martinfleis

   added

   Testing

   plotting

   on Jun 2, 2021
2. martinfleis commented on Jul 5, 2021

   

   martinfleis

   on Jul 5, 2021

   MemberAuthor

   More actions

   Colorbars are now plotted differently, there is no collection on their axis anymore, causing this line (and same below) to fail on IndexError: list index out of range

   geopandas/geopandas/tests/test_plotting.py

   Line 247 in fc61364

   cbar_colors = _get_colorbar_ax(ax.get_figure()).collections[-1].get_facecolors()

   I don't know how to get those colors anymore.

   The second failure here

   geopandas/geopandas/tests/test_plotting.py

   Line 736 in fc61364

   assert cax.get_ylabel() == label_txt

   is caused by reorganization of axes. So the label is now accessible as cax.child_axes[0].get_ylabel() instead of cax.get_ylabel(). Similarly, line 746 now needs to be cax.child_axes[0].get_xlabel().

   The last failure is caused by the fact that the colorbar axis does not have the label passed in divider.append_axes, hence has no name. Can be rewritten using

   plot_height = fig.axes[0].get_position().height
   legend_height =  fig.axes[1].get_position().height

   geopandas/geopandas/tests/test_plotting.py

   Lines 1193 to 1194 in fc61364

   	plot_height = _get_ax(fig, "").get_position().height
   	legend_height = _get_ax(fig, "fixed_colorbar").get_position().height

   I can fix the second and third issues now, I'd appreciate help with the first one if there's someone more familiar with matplotlib internals.
3. martinfleis

   self-assigned this

   on Jul 5, 2021
4. martinfleis

   added this to the 0.10 milestone on Jul 5, 2021
5. TLouf commented on Jul 7, 2021

   

   TLouf

   on Jul 7, 2021

   Last edited by TLouf

   Contributor

   More actions

   I don't know how to get those colors anymore.

   The breaking change from matplotlib is that the axis we get from _get_colorbar_ax, the one with label "<colorbar>", is no longer the one directly containing the pcolormesh. This is now drawn in a inset axis of the latter. To fix the test, _get_colorbar_ax should return this inset axis, by looking in the children of the currently returned axis for an axis with label "inset_axes". I made a quick test and it seems to work.

   Edit: well actually I now realize you had the solution in the remainder of your message, taking .child_axes[0], of which I ignored the existence, is simpler.
6. martinfleis commented on Jul 7, 2021

   

   martinfleis

   on Jul 7, 2021

   MemberAuthor

   More actions

   @TLouf would you like to turn it into a PR?
7. TLouf commented on Jul 7, 2021

   

   TLouf

   on Jul 7, 2021

   Contributor

   More actions

   Yes no problem, I'm on it.

   ❤️React with ❤️1Reacted by Martin Fleischmann
8. martinfleis

   closed this as completedin #2000on Jul 7, 2021
9. Zeroto521 commented on Jul 8, 2021

   

   Zeroto521

   on Jul 8, 2021

   Contributor

   More actions

   Guys.
   After matplotlib/matplotlib#20501 was merged, CI got fail again.

   There were some new changes to the colorbar.