Skip to content

If Paket crashes to some invalid user file: let's display the file to user so he/she can fix it. #730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
forki merged 3 commits into from
Mar 28, 2015
Merged

If Paket crashes to some invalid user file: let's display the file to user so he/she can fix it. #730

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31e8628
If user has some invalid xml-file, lets tell what that was!
Thorium Mar 27, 2015
d7c3954
Merge branch 'master' of https://github.com/Thorium/Paket
Thorium Mar 27, 2015
d710907
Logging to verbose
Thorium Mar 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/Paket.Core/BindingRedirects.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,14 @@ let internal setRedirect (doc:XDocument) bindingRedirect =

/// Applies a set of binding redirects to a single configuration file.
let private applyBindingRedirects bindingRedirects (configFilePath:string) =
let config = XDocument.Load(configFilePath, LoadOptions.PreserveWhitespace)
let config =
try
XDocument.Load(configFilePath, LoadOptions.PreserveWhitespace)
with
| :? System.Xml.XmlException as ex ->

@forki forki Mar 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens with other exceptions?

@Thorium Thorium Mar 27, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual: Paket just terminates. :-)
But this won't fix it, exception is re-thrown.

I think this is good info for non-verbose also: Code won't do anything in happy case scenario.

printfn "Illegal xml in file: %s" configFilePath

@forki forki Mar 27, 2015

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please use verbosefn

@Thorium Thorium Mar 27, 2015

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To test this code: Put some empty App.config file to your project and try to convert from nuget to paket.

raise ex

let config = Seq.fold setRedirect config bindingRedirects
config.Save configFilePath

Expand Down