Skip to content

Emtpy Choose MSBuild condition when adding FSharp.Core package #579

Description

@kurtschelfthout

Seems like paket is putting empty Choose conditions in my project files when I add FSharp.Core package. See fscheck/FsCheck@163062f

Sorry I did find a number of seemingly related issues, but not this exact thing, apologies if this is being tracked elsewhere.

Activity

  1. forki commented on Feb 3, 2015

    @forki
    Member

    I can confirm this is a bug. I just tried with latest release.

    Then I tried with latest alpha:

    image

    so it seems this is already fixed and even the xunit runner gets installed.

    Would be nice if you could test and let me know.

  2. forki commented on Feb 3, 2015

    @forki
    Member

    oups. Now I see the real issue.

    It seems we broke the install --hard mode. Then when conditions are empty because you already have FSharp.Core referenced (from the original fsproj template). If you run paket install --hard then we would normally remove the original reference and put everything into the when nodes.
    This behaviour is broken. I'll try to fix it, but as a workaround you can manually remove the FSharp.Core references from the fsproj files and rerun paket install

  3. forki commented on Feb 3, 2015

    @forki
    Member

    paket install --hard works now in latest release. You only have to call it once. Afterwards you can use paket install.

    image

  4. kurtschelfthout commented on Feb 3, 2015

    @kurtschelfthout
    ContributorAuthor

    👍 also for fixing the xunit thing.

    Just to confirm: this bug is fixed in latest, but to get xunit.runners to work I need alpha?

  5. forki commented on Feb 3, 2015

    @forki
    Member

    yep.

    since I want to hear +1 on the props/targets feature first.

  6. kurtschelfthout commented on Feb 3, 2015

    @kurtschelfthout
    ContributorAuthor

    Brilliant, works. Sorry, did not know references from another issue would re-open.

    fscheck/FsCheck@14c2e9d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions