Skip to content

Make the file search for app.config and web.config case insensitive - #493

Merged
isaacabraham merged 1 commit into
fsprojects:masterfrom
kerams:redirects-case
Dec 31, 2014
Merged

isaacabraham merged 1 commit into
fsprojects:masterfrom
kerams:redirects-case

Conversation

@kerams

@kerams kerams commented Dec 31, 2014

Copy link
Copy Markdown
Contributor

--redirects flag writes appropriate binding redirects to all app.config and web.config files. VS generates capitalized .config files (i.e. App.config), but the file search was case-sensitive, so nothing was written. This had me stumped for a long while.

@isaacabraham

Copy link
Copy Markdown
Contributor

good spot :-)

isaacabraham added a commit that referenced this pull request Dec 31, 2014
Make the file search for app.config and web.config case insensitive
@isaacabraham
isaacabraham merged commit 89e3f61 into fsprojects:master Dec 31, 2014
@forki

forki commented Dec 31, 2014

Copy link
Copy Markdown
Member

good

@agross

agross commented Dec 31, 2014

Copy link
Copy Markdown
Contributor

Probably not that important, but string comparison should be done using OrdinalIgnoreCase.

@kerams
kerams deleted the redirects-case branch December 31, 2014 15:52
@kerams

kerams commented Dec 31, 2014

Copy link
Copy Markdown
Contributor Author

@agross
You're right, I should've been more thorough. On the other hand, I don't think it will cause any problems in this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants