You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I have trouble with the number detection, which is used to correct the sorting of versions.
When we implement SemVer v2 this extra handling would not work anymore, as pre-release parts are separated with dots, not by dashes and parts should only be sorted numeric when they consist solely of numbers.
Current handling tries to separate a part into a name and a number, how should we proceed with this behavior?
I currently would suggest to revert #288 #288, as it's introduced the
bigger problem as it supposed to solve, and address all the things with #289#289.
—
Reply to this email directly or view it on GitHub #292 (comment).
Bug in resolution of pre-release versions is less important as a bug in resolution of normal version, so it was easy to decide. But thanks for kudos, I'm trying my best ;)
Activity
forki commentedon Oct 23, 2014
I assume the new semver parser doesn't flag as prerelease. The old one had
probably ignored the double dash versions
mexx commentedon Oct 23, 2014
Yes, it's the problem with numbers before dash.
forki commentedon Oct 23, 2014
Do you know how to fix it?
On Oct 23, 2014 9:04 PM, "Max Malook" notifications@github.com wrote:
mexx commentedon Oct 23, 2014
I'm looking currently into it.
mexx commentedon Oct 23, 2014
I have trouble with the number detection, which is used to correct the sorting of versions.
When we implement SemVer v2 this extra handling would not work anymore, as pre-release parts are separated with dots, not by dashes and parts should only be sorted numeric when they consist solely of numbers.
Current handling tries to separate a part into a name and a number, how should we proceed with this behavior?
mexx commentedon Oct 23, 2014
I currently would suggest to revert #288, as it's introduced the bigger problem as it supposed to solve, and address all the things with #289.
forki commentedon Oct 23, 2014
Ok good idea.
On Oct 23, 2014 9:40 PM, "Max Malook" notifications@github.com wrote:
forki commentedon Oct 23, 2014
done
forki commentedon Oct 23, 2014
Btw: big respect for such a suggestion. That's never easy.
mexx commentedon Oct 23, 2014
Bug in resolution of pre-release versions is less important as a bug in resolution of normal version, so it was easy to decide. But thanks for kudos, I'm trying my best ;)