github files are written as UTF-8, breaks for example .png-Files #247

Activity

1. forki commented on Oct 12, 2014

   

   forki

   on Oct 12, 2014

   Member

   More actions

   https://github.com/fsprojects/Paket/blob/master/src/Paket.Core/GitHub.fs#L30

   ideas how to fix?
2. mexx commented on Oct 12, 2014

   

   mexx

   on Oct 12, 2014

   ContributorAuthor

   More actions

   Download the file with AsyncDownloadFile instead of going through string.
   For raw file urls it should be better.
3. mexx commented on Oct 12, 2014

   

   mexx

   on Oct 12, 2014

   ContributorAuthor

   More actions

   I'll provide PR with the fix.
4. forki commented on Oct 12, 2014

   

   forki

   on Oct 12, 2014

   Member

   More actions

   Cool.
   On Oct 12, 2014 9:46 AM, "Max Malook" notifications@github.com wrote:

   I'll provide PR with the fix.

   —
   Reply to this email directly or view it on GitHub
   #247 (comment).
5. mexx

   added a commit that references this issue on Oct 12, 2014

   download github source files with correct encoding

   ...

   This issue will close once commit 9484385 is merged into the 'master' branch.

   9484385
6. forki

   closed this as completedin #248on Oct 12, 2014