Skip to content

Commit b954070

Browse files
committed
Use nameof for runtime method lookups and add inheritdoc tags
Replaced the string literals passed to `getRuntimeMethod` with `nameof` so a rename of `boxify`/`boxifyAsync`/`boxifyFilter`/`boxifyAsyncFilter`/ `boxifyTaskSeq`/`boxifyTaskSeqOption` is caught at compile time, and add `<inheritdoc/>` to the `IAsyncEnumerableFieldValue` member implementations.
1 parent 6639bd1 commit b954070

1 file changed

Lines changed: 9 additions & 6 deletions

File tree

‎src/FSharp.Data.GraphQL.Shared/TypeSystem.fs‎

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2384,8 +2384,11 @@ type internal AsyncEnumerableFieldValue<'Item> (source : IAsyncEnumerable<'Item>
23842384
}
23852385

23862386
interface IAsyncEnumerableFieldValue with
2387+
/// <inheritdoc/>
23872388
member _.Items = items
2389+
/// <inheritdoc/>
23882390
member _.MaxConcurrency = streaming.MaxConcurrency
2391+
/// <inheritdoc/>
23892392
member _.GetPreferredBatchSize () =
23902393
match streaming.Batching with
23912394
| StreamBatchingPolicy.NoBatching -> ValueNone
@@ -2486,17 +2489,17 @@ module Resolve =
24862489
let methods = typeof<Marker>.DeclaringType.GetRuntimeMethods ()
24872490
methods |> Seq.find (fun m -> m.Name.Equals name)
24882491

2489-
let private runtimeBoxify = getRuntimeMethod "boxify"
2492+
let private runtimeBoxify = getRuntimeMethod (nameof boxify)
24902493

2491-
let private runtimeBoxifyAsync = getRuntimeMethod "boxifyAsync"
2494+
let private runtimeBoxifyAsync = getRuntimeMethod (nameof boxifyAsync)
24922495

2493-
let private runtimeBoxifyFilter = getRuntimeMethod "boxifyFilter"
2496+
let private runtimeBoxifyFilter = getRuntimeMethod (nameof boxifyFilter)
24942497

2495-
let private runtimeBoxifyAsyncFilter = getRuntimeMethod "boxifyAsyncFilter"
2498+
let private runtimeBoxifyAsyncFilter = getRuntimeMethod (nameof boxifyAsyncFilter)
24962499

2497-
let private runtimeBoxifyTaskSeq = getRuntimeMethod "boxifyTaskSeq"
2500+
let private runtimeBoxifyTaskSeq = getRuntimeMethod (nameof boxifyTaskSeq)
24982501

2499-
let private runtimeBoxifyTaskSeqOption = getRuntimeMethod "boxifyTaskSeqOption"
2502+
let private runtimeBoxifyTaskSeqOption = getRuntimeMethod (nameof boxifyTaskSeqOption)
25002503

25012504
let private unwrapExpr =
25022505
function

0 commit comments

Comments
 (0)