Skip to content

[BUG] VineyardEngine.CheckRuntimeReady() always returns true without checking actual runtime state #6105

Description

@adityaupasani2

What's wrong

VineyardEngine.CheckRuntimeReady() in pkg/ddc/vineyard/runtime_info.go is an unimplemented stub:

func (e *VineyardEngine) CheckRuntimeReady() (ready bool) {
    //TODO implement me
    return true
}

This means data operations (DataLoad, DataMigrate, DataProcess) will be dispatched against a VineyardRuntime even when workers are not actually ready, potentially causing failures.

Impact

CheckRuntimeReady() is called in pkg/ddc/base/operation.go before executing data operations. Returning true unconditionally bypasses this gate entirely for VineyardRuntime.

Proposed fix

Implement it using the existing CheckWorkersReady() helper, same as the fix applied to ThinEngine in #6062. Fuse readiness is intentionally excluded because fluid treats fuse as always-ready by design (pkg/ctrl/fuse.go: "fluid assumes fuse components are always ready") — checkFuseHealthy() delegates to CheckAndSyncFuseStatus which unconditionally returns ready = true.

I'd like to work on this.

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions