Skip to content

Event and Power "requires_item" is unaware of parent items #1918

Description

@dorkster

An unfortunate side-effect of how we do procedural items is that they don't work as one might expect with features that reference items by ID. An example would be an Event's requires_item property. We want to check if the player has a Dagger by using requires_item=8. But if the player has a generated instance of a Dagger, requires_item (and in turn, ItemStorage::contains()) will not consider it to be a match.

  • Should base and generated items be treated as one in the same?
  • Checking if an item exists is fairly harmless, but what about removing items by ID? Maybe non-generated items should be prioritized, since the generated ones are probably what the player wants to keep.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions