Skip to content

Allow - in repo name #5561

Description

@haoxu0

Expected Behavior

Allow - in repo name such as "app-"

Current Behavior

  • is not allowed

Steps to reproduce

feast.repo_config.FeastConfigError: 1 validation error for RepoConfig
Value error, Project name: app-xxx, should only have alphanumerical values and underscores but not start with an underscore. [type=value_error, input_value='app-xxx', input_type=str]
For further information visit https://errors.pydantic.dev/2.10/v/value_error

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution

def is_valid_name(name: str) -> bool:
    """A name should be alphanumeric values, underscores, and hyphens but not start with an underscore"""
    return not name.startswith("_") and re.compile(r"[^\w-]+").search(name) is None

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions