Skip to content

Paket friendly Fabulous package #328

Closed

Description

@sergey-tihon

Not sure if it is actually Fabulous issues (just want to track is somewhere), but I think that would be nice to allow to manage Fabulous package using Paket easier.

I did migrate my test application (generated from Fabulous template to Paket) - sergey-tihon/MinMe@fb67ee5
It works, but require additional manual changes in project file after paket.exe install or update.

App.macOS.fsproj file is in old format and Paket insert all dependencies in proj file. In my case, project targets

<TargetFrameworkIdentifier>Xamarin.Mac</TargetFrameworkIdentifier>

Paket generate following XML during install

  <Choose>
    <When Condition="$(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0'">
      <ItemGroup>
        <Reference Include="Fabulous.Core">
          <HintPath>..\..\packages\Fabulous.Core\lib\netstandard2.0\Fabulous.Core.dll</HintPath>
          <Private>True</Private>
          <Paket>True</Paket>
        </Reference>
      </ItemGroup>
    </When>
  </Choose>

Then MSBuild cannot compile project for Xamarin.Mac because it does not see reference to Fabulous.Core.dll.

Workaround

Manually update condition in fsproj file for Fabulous.Core.dll and Fabulous.CustomControls.dll.

From

<When Condition="$(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0'">

To

<When Condition="($(TargetFrameworkIdentifier) == '.NETStandard' And $(TargetFrameworkVersion) == 'v2.0') 
Or ($(TargetFrameworkIdentifier) == 'Xamarin.Mac')">

Activity

  1. added a commit that references this issue on Feb 11, 2019
  2. TimLariviere commented on Feb 11, 2019

    @TimLariviere
    Member

    Last I checked, Paket is not really maintained up to date for Xamarin.
    A few months ago, I had to submit a PR to make it work for Xamarin.Android and Xamarin.iOS. (Paket thought Xamarin.Android/iOS didn't supported .NET Standard 2.0)

    Seems to be a similar issue.

  3. sergey-tihon commented on Apr 15, 2019

    @sergey-tihon
    Author

    Should be fixes starting from Paket 5.203.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions