Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ezolenko/rollup-plugin-typescript2
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.35.0
Choose a base ref
...
head repository: ezolenko/rollup-plugin-typescript2
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.36.0
Choose a head ref
  • 7 commits
  • 20 files changed
  • 2 contributors

Commits on Jul 10, 2023

  1. github: mark dist/* as generated code (#457)

    - per https://docs.github.com/en/repositories/working-with-files/managing-files/customizing-how-changed-files-appear-on-github
      - and https://github.com/github-linguist/linguist/blob/master/docs/overrides.md#generated-code
    
    - should help a good bit with making diffs more condensed by default
      - can still uncollapse generated code, just that default will be collapsed
    agilgur5 authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    61c7392 View commit details
    Browse the repository at this point in the history
  2. fix: hardcode declaration extension check (#456)

    * fix: preemptively `filter` type-only files to workaround Rollup bug
    
    - basically, right now, the addition of `this.load` on all `references` is causing Rollup to error out on JSON files
      - specifically, this is impacting `configPlugin` usage (i.e. `rollup.config.ts`), where previously one didn't need `@rollup/plugin-json`, but now it is erroring out without it
      - I tracked this down to be because of `this.load` specifically
      - to avoid this and similar such issues, we can preemptively `filter` out files before calling `this.resolve` / `this.load`, which should end up `exclude`ing JSON files and any other non-rpt2 files
        - this should also make it a bit more efficient to skip some recursion
        - and non-rpt2 files shouldn't include any type-only files
    
    - confirmed that this change fixes the error
      - and that the type-only tests still pass
    
    * refactor: use a common function for resolution checks
    
    - since the same logic is used in `resolveId` and these _should_ be equivalent
    
    - in the future, we might want to add more common logic to this function, e.g. `getAllReferences` removes `undefined` and uses `moduleNameResolver` as well, similar to `resolveId`
      - may not be so easy, so TBD
        - for instance, even moving the `undefined` check into the func required adding a type guard, as the compiler wasn't quite able to infer that passing the func meant it was not `undefined`
    
    * feat: also ignore `.d.cts` and `.d.mts` file extensions
    
    - support newer TS extensions
    
    - rpt2 should _always_ ignore declarations
      - regardless of the `exclude`; as in, if a user accidentally removes declarations in an override, rpt2 should still not directly read declarations
        - as they are normally read ambiently by TS and not _directly_ by Rollup or TS
    
    * fix comment -- there's more reasons why we shouldn't resolve all references
    
    - we don't `return false` in `resolveId`, so any new file that wasn't previously in Rollup's pipeline _must_ be resolved
      - `return` just defers to the next plugin, so, for a declaration, it eventually causes Rollup to try and fail to resolve on its own, giving an `Unexptected token` error message
      - but we _don't_ want to `return false` in `resolveId` if they _intentionally_ imported a declaration for some reason (e.g. if they're going to transform it in some way)
        - if we did `return false`, no other plugin could process either
      - so as a result, we should just never call `this.resolve()` on anything we don't expect to be able to resolve
        - i.e. don't add anything new to the pipeline that we don't resolve ourselves
    agilgur5 authored Jul 10, 2023
    Configuration menu
    Copy the full SHA
    976dadb View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. deps: auto-update semver via npm audit fix (#459)

    - updates several references to it in `package-lock.json`
    - removes a warning from NPM
    agilgur5 authored Jul 14, 2023
    Configuration menu
    Copy the full SHA
    b43001e View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. support newer moduleResolution kinds

    * moduleResolution classic is overridden to node10, all other values are passed through from tsconfig
    * updating dev typescript to 5.1.3
    ezolenko authored Jul 17, 2023
    Configuration menu
    Copy the full SHA
    ce2038d View commit details
    Browse the repository at this point in the history
  2. - build version

    ezolenko committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    fc85376 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. switching from tslint (deprecated) to eslint (#463)

    * - switching from tslint (deprecated) to eslint
    
    Co-authored-by: Anton Gilgur <4970083+agilgur5@users.noreply.github.com>
    ezolenko and agilgur5 authored Sep 26, 2023
    Configuration menu
    Copy the full SHA
    592ed5c View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. - build

    ezolenko committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    e9ede1d View commit details
    Browse the repository at this point in the history
Loading