Skip to content

Commit 21c7231

Browse files
remove channel from sequencer constructor
1 parent 45ba444 commit 21c7231

2 files changed

Lines changed: 15 additions & 13 deletions

File tree

‎sequencers/single/sequencer.go‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -53,17 +53,15 @@ func NewSequencer(
5353
batchTime time.Duration,
5454
metrics *Metrics,
5555
proposer bool,
56-
batchSubmissionChan chan coresequencer.Batch,
5756
) (*Sequencer, error) {
5857
s := &Sequencer{
59-
logger: logger,
60-
da: da,
61-
batchTime: batchTime,
62-
rollupId: rollupId,
63-
queue: NewBatchQueue(db, "batches"),
64-
batchSubmissionChan: batchSubmissionChan,
65-
metrics: metrics,
66-
proposer: proposer,
58+
logger: logger,
59+
da: da,
60+
batchTime: batchTime,
61+
rollupId: rollupId,
62+
queue: NewBatchQueue(db, "batches"),
63+
metrics: metrics,
64+
proposer: proposer,
6765
}
6866

6967
loadCtx, cancel := context.WithTimeout(context.Background(), 10*time.Second)

‎sequencers/single/sequencer_test.go‎

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ func TestNewSequencer(t *testing.T) {
2626
db := ds.NewMapDatastore()
2727
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
2828
defer cancel()
29-
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, []byte("rollup1"), 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
29+
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, []byte("rollup1"), 10*time.Second, metrics, false)
30+
seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
3031
if err != nil {
3132
t.Fatalf("Failed to create sequencer: %v", err)
3233
}
@@ -58,7 +59,8 @@ func TestSequencer_SubmitRollupBatchTxs(t *testing.T) {
5859
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
5960
defer cancel()
6061
rollupId := []byte("rollup1")
61-
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
62+
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false)
63+
seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
6264
if err != nil {
6365
t.Fatalf("Failed to create sequencer: %v", err)
6466
}
@@ -110,7 +112,8 @@ func TestSequencer_SubmitRollupBatchTxs_EmptyBatch(t *testing.T) {
110112
ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second)
111113
defer cancel()
112114
rollupId := []byte("rollup1")
113-
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
115+
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, dummyDA, rollupId, 10*time.Second, metrics, false)
116+
seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
114117
require.NoError(t, err, "Failed to create sequencer")
115118
defer func() {
116119
err := db.Close()
@@ -382,7 +385,8 @@ func TestSequencer_GetNextBatch_BeforeDASubmission(t *testing.T) {
382385
db := ds.NewMapDatastore()
383386
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second)
384387
defer cancel()
385-
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, mockDA, []byte("rollup1"), 1*time.Second, metrics, false, make(chan coresequencer.Batch, 100))
388+
seq, err := NewSequencer(ctx, log.NewNopLogger(), db, mockDA, []byte("rollup1"), 1*time.Second, metrics, false)
389+
seq.SetBatchSubmissionChan(make(chan coresequencer.Batch, 100))
386390
if err != nil {
387391
t.Fatalf("Failed to create sequencer: %v", err)
388392
}

0 commit comments

Comments
 (0)