Skip to content

Commit 6b430ae

Browse files
shs96cshs96c
committed
Move JS rules to a .bzl file
1 parent 828d539 commit 6b430ae

4 files changed

Lines changed: 14 additions & 15 deletions

File tree

‎javascript/atoms/fragments/BUCK‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include_defs('//javascript/JAVASCRIPT_DEFS')
1+
load("//javascript:rules.bzl", "closure_fragment")
22

33
closure_fragment(name = 'clear',
44
function = 'bot.action.clear',

javascript/JAVASCRIPT_DEFS renamed to javascript/rules.bzl

Lines changed: 11 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,37 @@
1-
orig_closure_fragment = closure_fragment
21

32
def closure_fragment(name, **kwargs):
4-
orig_closure_fragment(name, **kwargs)
3+
native.closure_fragment(name=name, **kwargs)
54

65
# Android
76
defs = kwargs.get('defines', [])
87
defs = defs + [
98
'goog.userAgent.ASSUME_MOBILE_WEBKIT=true',
109
'goog.userAgent.product.ASSUME_ANDROID=true']
11-
args = kwargs.copy();
10+
args = dict(**kwargs)
1211
args['defines'] = defs
1312
fragment_name = name + '-android'
14-
orig_closure_fragment(fragment_name, **args)
13+
native.closure_fragment(name=fragment_name, **args)
1514

1615
# Chrome
1716
defs = kwargs.get('defines', [])
1817
defs = defs + [
1918
'goog.userAgent.ASSUME_WEBKIT=true',
2019
'goog.userAgent.product.ASSUME_CHROME=true',
2120
]
22-
args = kwargs.copy();
21+
args = dict(**kwargs)
2322
args['defines'] = defs
2423
fragment_name = name + '-chrome'
25-
orig_closure_fragment(fragment_name, **args)
24+
native.closure_fragment(name=fragment_name, **args)
2625

2726
# Edge and IE
2827
defs = kwargs.get('defines', [])
2928
defs = defs + [
3029
'goog.userAgent.ASSUME_IE=true',
3130
]
32-
args = kwargs.copy();
31+
args = dict(**kwargs);
3332
args['defines'] = defs
3433
fragment_name = name + '-ie'
35-
orig_closure_fragment(fragment_name, **args)
34+
native.closure_fragment(name=fragment_name, **args)
3635

3736
# iOS
3837
defs = kwargs.get('defines', [])
@@ -41,10 +40,10 @@ def closure_fragment(name, **kwargs):
4140
# generic mobile webkit.
4241
'goog.userAgent.ASSUME_MOBILE_WEBKIT=true',
4342
]
44-
args = kwargs.copy();
43+
args = dict(**kwargs)
4544
args['defines'] = defs
4645
fragment_name = name + '-ios'
47-
orig_closure_fragment(fragment_name, **args)
46+
native.closure_fragment(name=fragment_name, **args)
4847

4948

5049
# Firefox
@@ -53,7 +52,7 @@ def closure_fragment(name, **kwargs):
5352
'goog.userAgent.ASSUME_GECKO=true',
5453
'goog.userAgent.product.ASSUME_FIREFOX=true',
5554
]
56-
args = kwargs.copy();
55+
args = dict(**kwargs);
5756
args['defines'] = defs
5857
fragment_name = name + '-firefox'
59-
orig_closure_fragment(fragment_name, **args)
58+
native.closure_fragment(name=fragment_name, **args)

‎javascript/selenium-atoms/BUCK‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include_defs('//javascript/JAVASCRIPT_DEFS')
1+
load('//javascript:rules.bzl', 'closure_fragment')
22

33
closure_library(name = 'deps',
44
srcs = glob(['*.js']),

‎javascript/webdriver/atoms/BUCK‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
include_defs('//javascript/JAVASCRIPT_DEFS')
1+
load("//javascript:rules.bzl", "closure_fragment")
22

33
closure_library(name = 'atoms-lib',
44
srcs = glob(['*.js', 'storage/*.js']),

0 commit comments

Comments
 (0)