Repository navigation

Commit 0ac09d0

authored and

committed

fix: add until.urlContains null value check (SeleniumHQ#5933)

`driver.getCurrentUrl()` can return `null` in some cases, which causes a `TypeError` instead of continuing to retry for the expected time.

1 parent 67b6e30 commit 0ac09d0Copy full SHA for 0ac09d0

1 file changed

javascript/node/selenium-webdriver/lib
- until.js

`‎javascript/node/selenium-webdriver/lib/until.js‎`

-Original file line number
+Diff line change
       'for URL to contain ' + JSON.stringify(substrUrl),
       function(driver) {
         return driver.getCurrentUrl().then(function(url) {
 -          return url.indexOf(substrUrl) !== -1;
 +          return url && url.indexOf(substrUrl) !== -1;
         });
       });
 };

Comments

(0)