Repository navigation
http2 code in Electron 5/6 suffers from a known memory leak #18817
Description
Preflight Checklist
- I have read the Contributing Guidelines for this project.
- I agree to follow the Code of Conduct that this project adheres to.
- I have searched the issue tracker for a feature request that matches the one I want to file, without success.
Problem Description
The current version of node (12.0.0) that is embedded in Electron suffers from a memory leak in the http2 code that makes it impossible to use grpc without fatal memory overflow errors.
The issues has been resolved in nodejs/node#27914 and the fix is included in node v12.4.0
Proposed Solution
Update node to 12.4.0
Alternatives Considered
Without this upgrade, the only way to use grpc is to downgrade Electron to v4.
Activity
MarshallOfSound commentedon Jun 16, 2019
As per our versioning policy a minor bump in node would be a minor bump in Electron. It would be easier / make more sense for us to float the individual patch commit onto our node branch.
Refs: nodejs/node@b84b4d8
[-]Update Node version to 12.4.0[/-][+]http2 code in Electron 5/6 suffers from a known memory leak[/+]mrfelton commentedon Jun 18, 2019
Hi. Thanks for the info. Can you give any pointers as to where these change needs to be made? We're currently unable to release until this issues is resolved (or face the prospect of having to downgrade to electron v4). Any thoughts as to when it's likely that this could get fixed and released into 5.x?