Skip to content

Commit f3526bc

Browse files
committed
src: allow embedder control of code generation policy
nodejs/node#46368
1 parent 0c7bda2 commit f3526bc

3 files changed

Lines changed: 2 additions & 45 deletions

File tree

‎patches/node/.patches‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ api_pass_oomdetails_to_oomerrorcallback.patch
2929
fix_expose_lookupandcompile_with_parameters.patch
3030
fix_prevent_changing_functiontemplateinfo_after_publish.patch
3131
enable_crashpad_linux_node_processes.patch
32-
allow_embedder_to_control_codegenerationfromstringscallback.patch
3332
src_allow_optional_isolation_termination_in_node.patch
3433
test_mark_cpu_prof_tests_as_flaky_in_electron.patch
3534
lib_fix_broadcastchannel_initialization_location.patch

‎patches/node/allow_embedder_to_control_codegenerationfromstringscallback.patch‎

Lines changed: 0 additions & 44 deletions
This file was deleted.

‎shell/common/node_bindings.cc‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -599,6 +599,8 @@ node::Environment* NodeBindings::CreateEnvironment(
599599
// Use a custom callback here to allow us to leverage Blink's logic in the
600600
// renderer process.
601601
is.allow_wasm_code_generation_callback = AllowWasmCodeGenerationCallback;
602+
is.flags |= node::IsolateSettingsFlags::
603+
ALLOW_MODIFY_CODE_GENERATION_FROM_STRINGS_CALLBACK;
602604
is.modify_code_generation_from_strings_callback =
603605
ModifyCodeGenerationFromStrings;
604606

0 commit comments

Comments
 (0)