Skip to content

Commit 77cab1c

Browse files
ckerrGitHub Copilot
authored andcommitted
fix(patch): release cppgc wrapper tracking nodes
Ref: nodejs/node#56534 Co-Authored-By: GitHub Copilot <copilot@github.com>
1 parent 4f84f19 commit 77cab1c

1 file changed

Lines changed: 18 additions & 0 deletions

File tree

‎patches/node/refactor_attach_cppgc_heap_on_v8_isolate_creation.patch‎

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,24 @@ index 745ecab746f7c7540733d31a94f52809dcddd5be..0e52bf5a6f4837d0f4bfed83987c6903
7575
return ptr;
7676
}
7777

78+
diff --git a/src/cppgc_helpers.cc b/src/cppgc_helpers.cc
79+
index 7c557a822d2028aa88adbdca63677a44afd1a120..ae7e45fbc26317a53207c267865ea4db553f5a8a 100644
80+
--- a/src/cppgc_helpers.cc
81+
+++ b/src/cppgc_helpers.cc
82+
@@ -4,11 +4,12 @@
83+
namespace node {
84+
85+
void CppgcWrapperList::Cleanup() {
86+
- for (auto node : *this) {
87+
+ while (CppgcWrapperListNode* node = PopFront()) {
88+
CppgcMixin* ptr = node->persistent.Get();
89+
if (ptr != nullptr) {
90+
ptr->Finalize();
91+
}
92+
+ delete node;
93+
}
94+
}
95+
7896
diff --git a/src/cppgc_helpers.h b/src/cppgc_helpers.h
7997
index fb2af584a4ae777022c9ef8c20ada1edcbbbefdc..fe6300a5d5d2d6602a84cbd33736c2133041d1b0 100644
8098
--- a/src/cppgc_helpers.h

0 commit comments

Comments
 (0)