Skip to content

Minify dist file #14

Closed
Closed
Minify dist file#14

Description

@ericmdantas
ericmdantas
opened on Jan 13, 2016

Is there any specific reason not to minify dist/datime.js?

If you guys want it, I can send a PR to do it.

Great module, by the way.

Activity

  1. eight04 commented on Jan 14, 2016

    @eight04
    eight04
    on Jan 14, 2016
    Owner

    I think it's not that necessary to minify them because most of the developers have their own build tool, which not only minify js but concat each modules into one js file.

  2. ericmdantas commented on Jan 14, 2016

    @ericmdantas
    ericmdantas
    on Jan 14, 2016
    Author

    Well, we could have both files, actually. A minified and a not minified one - which is pretty common.

    But that's up to you.

  3. eight04 commented on Jan 16, 2016

    @eight04
    eight04
    on Jan 16, 2016
    Owner

    It is good to have both 👍

  4. ericmdantas commented on Jan 16, 2016

    @ericmdantas
    ericmdantas
    on Jan 16, 2016
    Author

    I'll send a PR soon.

  5. eight04 commented on Sep 16, 2017

    @eight04
    eight04
    on Sep 16, 2017
    Owner

    Fixed in 5.2.0.

  6. eight04
    closed this as completedon Sep 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions