Skip to content

Commit 99ad9ef

Browse files
committed
add tests for identity v3 endpoint
Change-Id: I1479460473656ea4e2a48a976808371e840b49c1 Closes-Bug: #1348867
1 parent 0cfd0b1 commit 99ad9ef

3 files changed

Lines changed: 602 additions & 5 deletions

File tree

‎openstackclient/identity/v3/endpoint.py‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,12 @@ def get_parser(self, prog_name):
165165
'--enable',
166166
dest='enabled',
167167
action='store_true',
168-
default=True,
169168
help='Enable endpoint',
170169
)
171170
enable_group.add_argument(
172171
'--disable',
173-
dest='enabled',
174-
action='store_false',
172+
dest='disabled',
173+
action='store_true',
175174
help='Disable endpoint',
176175
)
177176
return parser
@@ -183,7 +182,8 @@ def take_action(self, parsed_args):
183182
parsed_args.endpoint)
184183

185184
if (not parsed_args.interface and not parsed_args.url
186-
and not parsed_args.service and not parsed_args.region):
185+
and not parsed_args.service and not parsed_args.region
186+
and not parsed_args.enabled and not parsed_args.disabled):
187187
sys.stdout.write("Endpoint not updated, no arguments present")
188188
return
189189

@@ -192,13 +192,19 @@ def take_action(self, parsed_args):
192192
service = common.find_service(identity_client, parsed_args.service)
193193
service_id = service.id
194194

195+
enabled = None
196+
if parsed_args.enabled:
197+
enabled = True
198+
if parsed_args.disabled:
199+
enabled = False
200+
195201
identity_client.endpoints.update(
196202
endpoint.id,
197203
service=service_id,
198204
url=parsed_args.url,
199205
interface=parsed_args.interface,
200206
region=parsed_args.region,
201-
enabled=parsed_args.enabled
207+
enabled=enabled
202208
)
203209

204210
return

‎openstackclient/tests/identity/v3/fakes.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,20 @@
7474
'enabled': True,
7575
}
7676

77+
endpoint_id = 'e-123'
78+
endpoint_url = 'http://127.0.0.1:35357'
79+
endpoint_region = 'RegionOne'
80+
endpoint_interface = 'admin'
81+
82+
ENDPOINT = {
83+
'id': endpoint_id,
84+
'url': endpoint_url,
85+
'region': endpoint_region,
86+
'interface': endpoint_interface,
87+
'service_id': service_id,
88+
'enabled': True,
89+
}
90+
7791
user_id = 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa'
7892
user_name = 'paul'
7993
user_description = 'Sir Paul'
@@ -182,6 +196,8 @@ class FakeIdentityv3Client(object):
182196
def __init__(self, **kwargs):
183197
self.domains = mock.Mock()
184198
self.domains.resource_class = fakes.FakeResource(None, {})
199+
self.endpoints = mock.Mock()
200+
self.endpoints.resource_class = fakes.FakeResource(None, {})
185201
self.groups = mock.Mock()
186202
self.groups.resource_class = fakes.FakeResource(None, {})
187203
self.oauth1 = mock.Mock()

0 commit comments

Comments
 (0)