Skip to content

Docsify does not preserve alias when importing an image #1870

Description

@hamishwillee

Bug Report

Steps to reproduce

This page https://github.com/hamishwillee/mavlink-devguide/blob/demo_for_but/en/guide/serialization.md displays four images.

  • The first two display an image in an /assets/ folder using absolute and relative paths.
  • The second two display the same image in the same folder.
1. 
   ![MAVLink v2 packet](../../assets/packets/packet_mavlink_v2.jpg) 

2. 
   ![MAVLink v2 packet](/assets/packets/packet_mavlink_v2.jpg)

3. 
   ![MAVLink v2 packet](packet_mavlink_v2.jpg)

4. 
   <img src="packet_mavlink_v2.jpg" title="MAVLink v2 packet">

If I display this page using an alias none of the images are displayed;

'/en/(.*)':
  'https://raw.githubusercontent.com/hamishwillee/mavlink-devguide/docsify_test/en/$1'

YOu can see why here - the assets folder is not found - either it can't find the assets folder, or it is looking in the root, or it is looking in the right folder locally, and not on the aliased site.

image

I think it should search the relative path of the alias to construct the URL.

What is current behaviour

If you load a markdown file using an alias images listed in that file cannot be imported.

What is the expected behaviour

If you import a file via an alias its images should be displayed

Other relevant information

I think this is the same thing reported in #1436 (comment)

The had a horrible hack to hard code what site they are on into the URL. I'd be OK with that if you could get the information for your current context dynamically maybe, but I'd still hope this bug would be fixed.

  • [ x] Bug does still occur when all/other plugins are disabled?

  • Your OS: Windows 11

  • Node.js version: v16.15.0

  • npm/yarn version: yarn 1.22.5

  • Browser version: Latest Firefox and Chrome

  • Docsify version: 4.x

  • Docsify plugins: None

Please create a reproducible sandbox

[Edit 307qqv236](https://codesandbox.io/s/late-dawn-tvrd7w?file=/README.md)

  • click the link to display a test page that loads images

Mention the docsify version in which this bug was not present (if any)

All

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions