Skip to content

Commit dd13134

Browse files
claudef3l1x
claude
authored and
f3l1x
committed
Fix '|| true' that can hide build failures
&& and || bind equally, so a bare '|| true' rescued any earlier failure in the RUN chain and produced broken images that still built. Chowns are now plain commands; the claude chmod fallback is in parentheses. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S9abShYK5RMmbeuZurGH3b
1 parent 673f137 commit dd13134

5 files changed

Lines changed: 10 additions & 10 deletions

File tree

‎fx/Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -119,8 +119,8 @@ RUN \
119119
echo 'export XDG_RUNTIME_DIR="${XDG_RUNTIME_DIR:-/run/user/$(id -u)}"' >> /etc/profile && \
120120
echo 'export DOCKER_HOST="unix://${XDG_RUNTIME_DIR}/docker.sock"' >> /etc/profile && \
121121
# OWNERSHIP (coder can upgrade tools) ######################################
122-
chown coder:coder /usr/local/bin/claude /usr/local/bin/opencode 2>/dev/null || true && \
123-
chown -R coder:coder /home/coder/go 2>/dev/null || true && \
122+
chown coder:coder /usr/local/bin/claude /usr/local/bin/opencode && \
123+
chown -R coder:coder /home/coder/go && \
124124
# CLEANUP ###################################################################
125125
apt-get clean -y && \
126126
apt-get autoclean -y && \

‎golang/Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ RUN \
4848
mkdir -p /home/coder/.local/bin && \
4949
if [ -f /root/.local/bin/claude ]; then cp /root/.local/bin/claude /home/coder/.local/bin/claude; fi && \
5050
if [ -f /root/bin/claude ]; then cp /root/bin/claude /home/coder/.local/bin/claude; fi && \
51-
chmod +x /home/coder/.local/bin/claude 2>/dev/null || true && \
51+
(chmod +x /home/coder/.local/bin/claude 2>/dev/null || true) && \
5252
ln -sf /home/coder/.local/bin/claude /usr/local/bin/claude && \
5353
# OPENCODE ##################################################################
5454
curl -fsSL https://opencode.ai/install | VERSION=${OPENCODE_VERSION} bash -s -- --no-modify-path && \
@@ -71,7 +71,7 @@ RUN \
7171
echo 'export GOPATH="$HOME/go"' >> /etc/profile && \
7272
echo 'export PATH="$GOROOT/bin:$GOPATH/bin:$PATH"' >> /etc/profile && \
7373
# OWNERSHIP ################################################################
74-
chown -R coder:coder /home/coder/.local /home/coder/.opencode /home/coder/go 2>/dev/null || true && \
74+
chown -R coder:coder /home/coder/.local /home/coder/.opencode /home/coder/go && \
7575
# CLEANUP ###################################################################
7676
apt-get clean -y && \
7777
apt-get autoclean -y && \

‎nodejs/Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ RUN \
4444
mkdir -p /home/coder/.local/bin && \
4545
if [ -f /root/.local/bin/claude ]; then cp /root/.local/bin/claude /home/coder/.local/bin/claude; fi && \
4646
if [ -f /root/bin/claude ]; then cp /root/bin/claude /home/coder/.local/bin/claude; fi && \
47-
chmod +x /home/coder/.local/bin/claude 2>/dev/null || true && \
47+
(chmod +x /home/coder/.local/bin/claude 2>/dev/null || true) && \
4848
ln -sf /home/coder/.local/bin/claude /usr/local/bin/claude && \
4949
# OPENCODE ##################################################################
5050
curl -fsSL https://opencode.ai/install | VERSION=${OPENCODE_VERSION} bash -s -- --no-modify-path && \
@@ -68,7 +68,7 @@ RUN \
6868
echo '[ -d "$DENO_INSTALL/bin" ] && export PATH="$DENO_INSTALL/bin:$PATH"' >> /etc/profile && \
6969
echo '[ -d "$BUN_INSTALL/bin" ] && export PATH="$BUN_INSTALL/bin:$PATH"' >> /etc/profile && \
7070
# OWNERSHIP ################################################################
71-
chown -R coder:coder /home/coder/.local /home/coder/.opencode 2>/dev/null || true && \
71+
chown -R coder:coder /home/coder/.local /home/coder/.opencode && \
7272
# CLEANUP ###################################################################
7373
apt-get clean -y && \
7474
apt-get autoclean -y && \

‎php/Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ RUN \
5151
mkdir -p /home/coder/.local/bin && \
5252
if [ -f /root/.local/bin/claude ]; then cp /root/.local/bin/claude /home/coder/.local/bin/claude; fi && \
5353
if [ -f /root/bin/claude ]; then cp /root/bin/claude /home/coder/.local/bin/claude; fi && \
54-
chmod +x /home/coder/.local/bin/claude 2>/dev/null || true && \
54+
(chmod +x /home/coder/.local/bin/claude 2>/dev/null || true) && \
5555
ln -sf /home/coder/.local/bin/claude /usr/local/bin/claude && \
5656
# OPENCODE ##################################################################
5757
curl -fsSL https://opencode.ai/install | VERSION=${OPENCODE_VERSION} bash -s -- --no-modify-path && \
@@ -68,7 +68,7 @@ RUN \
6868
npm install -g agent-browser && \
6969
runuser -u coder -- agent-browser install && \
7070
# OWNERSHIP ################################################################
71-
chown -R coder:coder /home/coder/.local /home/coder/.opencode 2>/dev/null || true && \
71+
chown -R coder:coder /home/coder/.local /home/coder/.opencode && \
7272
# CLEANUP ###################################################################
7373
apt-get clean -y && \
7474
apt-get autoclean -y && \

‎python/Dockerfile‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ RUN \
4040
mkdir -p /home/coder/.local/bin && \
4141
if [ -f /root/.local/bin/claude ]; then cp /root/.local/bin/claude /home/coder/.local/bin/claude; fi && \
4242
if [ -f /root/bin/claude ]; then cp /root/bin/claude /home/coder/.local/bin/claude; fi && \
43-
chmod +x /home/coder/.local/bin/claude 2>/dev/null || true && \
43+
(chmod +x /home/coder/.local/bin/claude 2>/dev/null || true) && \
4444
ln -sf /home/coder/.local/bin/claude /usr/local/bin/claude && \
4545
# OPENCODE ##################################################################
4646
curl -fsSL https://opencode.ai/install | VERSION=${OPENCODE_VERSION} bash -s -- --no-modify-path && \
@@ -57,7 +57,7 @@ RUN \
5757
npm install -g agent-browser && \
5858
runuser -u coder -- agent-browser install && \
5959
# OWNERSHIP ################################################################
60-
chown -R coder:coder /home/coder/.local /home/coder/.opencode 2>/dev/null || true && \
60+
chown -R coder:coder /home/coder/.local /home/coder/.opencode && \
6161
# CLEANUP ###################################################################
6262
apt-get clean -y && \
6363
apt-get autoclean -y && \

0 commit comments

Comments
 (0)