Skip to content

Commit b95475d

Browse files
committed
Enforce unit tests for @extra
1 parent da07f1f commit b95475d

2 files changed

Lines changed: 21 additions & 17 deletions

File tree

‎AndroidAnnotations/functional-test-1-5-tests/src/test/java/org/androidannotations/test15/InjectExtraTest.java‎

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -23,32 +23,33 @@
2323
import org.junit.Test;
2424
import org.junit.runner.RunWith;
2525

26-
import android.content.Intent;
26+
import android.app.Activity;
27+
import android.content.Context;
2728

2829
@RunWith(AndroidAnnotationsTestRunner.class)
2930
public class InjectExtraTest {
3031

31-
private Intent intent;
3232
private ExtraInjectedActivity_ activity;
33+
private Context context = new Activity();
3334

3435
@Before
3536
public void setup() {
3637
activity = new ExtraInjectedActivity_();
37-
intent = new Intent();
38-
activity.setIntent(intent);
3938
}
4039

4140
@Test
4241
public void simple_string_extra_injected() {
43-
intent.putExtra("stringExtra", "Hello!");
42+
activity.setIntent(ExtraInjectedActivity_.intent(context)
43+
.stringExtra("Hello!").get());
4444
activity.onCreate(null);
4545
assertThat(activity.stringExtra).isEqualTo("Hello!");
4646
}
4747

4848
@Test
4949
public void array_extra_injected() {
5050
CustomData[] customData = { new CustomData("42") };
51-
intent.putExtra("arrayExtra", customData);
51+
activity.setIntent(ExtraInjectedActivity_.intent(context)
52+
.arrayExtra(customData).get());
5253
activity.onCreate(null);
5354
assertThat(activity.arrayExtra).isEqualTo(customData);
5455
}
@@ -57,42 +58,45 @@ public void array_extra_injected() {
5758
public void list_extra_injected() {
5859
ArrayList<String> list = new ArrayList<String>();
5960
list.add("Hello !");
60-
intent.putExtra("listExtra", list);
61+
activity.setIntent(ExtraInjectedActivity_.intent(context)
62+
.listExtra(list).get());
6163
activity.onCreate(null);
6264
assertThat(activity.listExtra).isEqualTo(list);
6365
}
6466

6567
@Test
6668
public void int_extra_injected() {
67-
intent.putExtra("intExtra", 42);
69+
activity.setIntent(ExtraInjectedActivity_.intent(context).intExtra(42)
70+
.get());
6871
activity.onCreate(null);
6972
assertThat(activity.intExtra).isEqualTo(42);
7073
}
7174

7275
@Test
7376
public void int_array_extra_injected() {
7477
byte[] byteArray = { 0, 2 };
75-
intent.putExtra("byteArrayExtra", byteArray);
78+
activity.setIntent(ExtraInjectedActivity_.intent(context)
79+
.byteArrayExtra(byteArray).get());
7680
activity.onCreate(null);
7781
assertThat(activity.byteArrayExtra).isEqualTo(byteArray);
7882
}
7983

8084
@Test
8185
public void setIntent_reinjects_extra() {
82-
intent.putExtra("stringExtra", "Hello!");
86+
activity.setIntent(ExtraInjectedActivity_.intent(context)
87+
.stringExtra("Hello!").get());
8388
activity.onCreate(null);
8489

85-
Intent newIntent = new Intent();
86-
newIntent.putExtra("stringExtra", "Hello Again!");
87-
88-
activity.setIntent(newIntent);
90+
activity.setIntent(ExtraInjectedActivity_.intent(context)
91+
.stringExtra("Hello Again!").get());
8992

9093
assertThat(activity.stringExtra).isEqualTo("Hello Again!");
9194
}
92-
95+
9396
@Test
9497
public void extraWithoutValueInjected() {
95-
intent.putExtra("extraWithoutValue", "Hello!");
98+
activity.setIntent(ExtraInjectedActivity_.intent(context)
99+
.extraWithoutValue("Hello!").get());
96100
activity.onCreate(null);
97101
assertThat(activity.extraWithoutValue).isEqualTo("Hello!");
98102
}

‎AndroidAnnotations/functional-test-1-5/src/main/java/org/androidannotations/test15/ExtraInjectedActivity.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
@EActivity
2727
public class ExtraInjectedActivity extends Activity {
2828

29-
@Extra("stringExtra")
29+
@Extra("aStringExtra")
3030
String stringExtra;
3131

3232
@Extra("arrayExtra")

0 commit comments

Comments
 (0)