Skip to content

Commit 9547642

Browse files
authored
Fixes a bug were the incident summary table was attempting to show the edit incident pane. (Netflix#907)
1 parent f3d2668 commit 9547642

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

‎src/dispatch/static/dispatch/src/incident/IncidentSummaryTable.vue‎

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
<template>
22
<div>
3-
<edit-sheet />
43
<v-data-table :headers="headers" :items="items" :loading="loading" hide-default-footer>
54
<template v-slot:item.incident_priority.name="{ item }">
65
<incident-priority :priority="item.incident_priority.name" />
@@ -23,8 +22,8 @@
2322
</v-btn>
2423
</template>
2524
<v-list>
26-
<v-list-item @click="showEditSheet(item)">
27-
<v-list-item-title>Edit / View</v-list-item-title>
25+
<v-list-item :to="`/incidents/${item.name}`">
26+
<v-list-item-title>View / Edit</v-list-item-title>
2827
</v-list-item>
2928
</v-list>
3029
</v-menu>
@@ -37,7 +36,6 @@ import { mapActions } from "vuex"
3736
3837
import IncidentPriority from "@/incident/IncidentPriority.vue"
3938
import IncidentStatus from "@/incident/IncidentStatus"
40-
import EditSheet from "@/incident/EditSheet.vue"
4139
import IncidentParticipant from "@/incident/Participant.vue"
4240
4341
export default {
@@ -46,8 +44,7 @@ export default {
4644
components: {
4745
IncidentPriority,
4846
IncidentStatus,
49-
IncidentParticipant,
50-
EditSheet
47+
IncidentParticipant
5148
},
5249
5350
data() {

‎src/dispatch/static/dispatch/src/incident/Status.vue‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
</template>
2121

2222
<script>
23-
import { mapActions } from "vuex"
2423
import IncidentApi from "@/incident/api"
2524
import IncidentSummaryTable from "@/incident/IncidentSummaryTable.vue"
2625
@@ -49,8 +48,7 @@ export default {
4948
this.items = response.data.items
5049
this.loading = false
5150
})
52-
},
53-
...mapActions("incident", ["joinIncident"])
51+
}
5452
}
5553
}
5654
</script>

‎src/dispatch/static/dispatch/src/router/config.js‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,13 @@ export const protectedRoute = [
5858
{
5959
path: "/incidents",
6060
component: DefaultLayout,
61-
meta: { title: "Incidents", icon: "view_compact", group: "incidents", requiresAuth: true },
61+
meta: {
62+
title: "Incidents",
63+
icon: "view_compact",
64+
group: "incidents",
65+
requiresAuth: true,
66+
showEditSheet: false
67+
},
6268
children: [
6369
{
6470
path: "",

0 commit comments

Comments
 (0)