You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@sbillinge I just checked the recent v1.4.1 GitHub release, and it seems like it has it was tagged on the wrong branch. It has commits up to #34 (main branch) but we need to have commits up to #39 (windows branch).
Now we also have the new workflow, which only requires to push the tag and it will automatically GitHub release and generate sha256 in the release message.
@sbillinge I think we are probably safe to merge it now. Or maybe we want someone to test the new diffpy.srreal release backend by this new libdiffpy? I'll make the full conda-forge release recipe update now
Let's have Caden see if he can get srreal to pass tests now. Then let me know and I will merge to main and redo the release. The release bundle will be the same, but it may be confusing if metadata about some weird windows branch is hanging around.
Activity
sbillinge commentedon Jun 25, 2025
thanks for letting me know. I will try and do that release again.....
sbillinge commentedon Jun 25, 2025
OK, I pushed a new tag. It seemed to make the new release on GH automatically. Please could you check it?
Tieqiong commentedon Jun 25, 2025
@sbillinge Thanks! I think it's correct now.
sbillinge commentedon Jun 25, 2025
At what point do we want to merge windows into main?
Tieqiong commentedon Jun 25, 2025
@sbillinge I think we are probably safe to merge it now. Or maybe we want someone to test the new
diffpy.srrealrelease backend by this newlibdiffpy? I'll make the full conda-forge release recipe update nowsbillinge commentedon Jun 25, 2025
Let's have Caden see if he can get srreal to pass tests now. Then let me know and I will merge to main and redo the release. The release bundle will be the same, but it may be confusing if metadata about some weird windows branch is hanging around.