Skip to content

Commit 248bb9a

Browse files
kdavisk6velo
authored andcommitted
Moves Java8 into Core (OpenFeign#732)
* Moves Java8 into Core Moves the OptionalDecoder and StreamDecoder into Feign Core Removes Java8 library Closes 705 * fixup! Moves Java8 into Core
1 parent ed2cef0 commit 248bb9a

9 files changed

Lines changed: 13 additions & 27 deletions

File tree

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
### Version 10.0
2+
* Feign baseline is now JDK 8
3+
14
### Version 9.6
25
* Feign builder now supports flag `doNotCloseAfterDecode` to support lazy iteration of responses.
36
* Adds `JacksonIteratorDecoder` and `StreamDecoder` to decode responses as `java.util.Iterator` or `java.util.stream.Stream`.

‎benchmark/pom.xml‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@
5252
<artifactId>feign-jackson</artifactId>
5353
<version>${project.version}</version>
5454
</dependency>
55-
<dependency>
56-
<groupId>${project.groupId}</groupId>
57-
<artifactId>feign-java8</artifactId>
58-
<version>${project.version}</version>
59-
</dependency>
6055
<dependency>
6156
<groupId>com.squareup.okhttp</groupId>
6257
<artifactId>mockwebserver</artifactId>

‎core/pom.xml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,13 @@
5656
<version>4.2.5.RELEASE</version>
5757
<scope>test</scope>
5858
</dependency>
59+
60+
<dependency>
61+
<groupId>com.fasterxml.jackson.core</groupId>
62+
<artifactId>jackson-databind</artifactId>
63+
<version>${jackson.version}</version>
64+
<scope>test</scope>
65+
</dependency>
5966
</dependencies>
6067

6168
<build>

java8/src/main/java/feign/optionals/OptionalDecoder.java renamed to core/src/main/java/feign/optionals/OptionalDecoder.java

File renamed without changes.
File renamed without changes.

java8/src/test/java/feign/optionals/OptionalDecoderTests.java renamed to core/src/test/java/feign/optionals/OptionalDecoderTests.java

File renamed without changes.

java8/src/test/java/feign/stream/StreamDecoderTest.java renamed to core/src/test/java/feign/stream/StreamDecoderTest.java

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import feign.Feign;
1919
import feign.RequestLine;
2020
import feign.Response;
21-
import feign.jackson.JacksonIteratorDecoder;
2221
import java.io.BufferedReader;
2322
import java.io.Closeable;
2423
import java.io.IOException;
@@ -61,7 +60,7 @@ class Car {
6160
+ "]\n";
6261

6362
@Test
64-
public void simpleStreamTest() throws IOException, InterruptedException {
63+
public void simpleStreamTest() {
6564
MockWebServer server = new MockWebServer();
6665
server.enqueue(new MockResponse().setBody("foo\nbar"));
6766

@@ -76,23 +75,6 @@ public void simpleStreamTest() throws IOException, InterruptedException {
7675
}
7776
}
7877

79-
@Test
80-
public void simpleJsonStreamTest() throws IOException, InterruptedException {
81-
MockWebServer server = new MockWebServer();
82-
server.enqueue(new MockResponse().setBody(carsJson));
83-
84-
ObjectMapper mapper = new ObjectMapper();
85-
86-
StreamInterface api = Feign.builder()
87-
.decoder(StreamDecoder.create(JacksonIteratorDecoder.create()))
88-
.doNotCloseAfterDecode()
89-
.target(StreamInterface.class, server.url("/").toString());
90-
91-
try (Stream<StreamInterface.Car> stream = api.getCars()) {
92-
assertThat(stream.collect(Collectors.toList())).hasSize(2);
93-
}
94-
}
95-
9678
@Test
9779
public void shouldCloseIteratorWhenStreamClosed() throws IOException {
9880
Response response = Response.builder()
@@ -119,7 +101,7 @@ static class TestCloseableIterator implements Iterator<String>, Closeable {
119101
boolean closed;
120102

121103
@Override
122-
public void close() throws IOException {
104+
public void close() {
123105
this.closed = true;
124106
}
125107

‎jackson/src/test/java/feign/jackson/JacksonCodecTest.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ public void customEncoder() throws Exception {
155155
encoder.encode(zones, new TypeReference<List<Zone>>() {}.getType(), template);
156156

157157
assertThat(template).hasBody("" //
158-
+ "[ {" + System.lineSeparator()
158+
+ "[ {" + System.lineSeparator()
159159
+ " \"name\" : \"DENOMINATOR.IO.\"" + System.lineSeparator()
160160
+ "}, {" + System.lineSeparator()
161161
+ " \"name\" : \"DENOMINATOR.IO.\"," + System.lineSeparator()

‎pom.xml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
<module>ribbon</module>
3737
<module>sax</module>
3838
<module>slf4j</module>
39-
<module>java8</module>
4039
<module>mock</module>
4140
<module>benchmark</module>
4241
</modules>

0 commit comments

Comments
 (0)