Node v12 breaks addForeignKey #635

Activity

1. wzrdtales

   added

   bug

   on Jul 14, 2019
2. wzrdtales commented on Jul 14, 2019

   

   wzrdtales

   on Jul 14, 2019

   Member

   More actions

   Might be a similar issue as on one of the other drivers. I will check this. Thank you for reporting!
3. lukemuller commented on Jul 14, 2019

   

   lukemuller

   on Jul 14, 2019

   Author

   More actions

   I think I’ve found the issue. I checked the v12 changelogs to the util. And it appears this change was implemented: nodejs/node#23162

   It looks like the formatter now checks if the value is a function and uses util.inspect rather than returning a string before. So the ddlescape function in the formatter is now causing an issue.
4. grappetite-ali commented on Oct 8, 2019

   

   grappetite-ali

   on Oct 8, 2019

   More actions

   I am facing same issue.
5. coffeestains1908 commented on Nov 2, 2019

   

   coffeestains1908

   on Nov 2, 2019

   More actions

   This is also happening on Windows 10

   db-migrate: 0.11.6
   db-migrate-mysql: 1.1.10
   nodejs: v12.13.0
   

   // add foreign key
   exports.up = function(db, cb) {
     db.addForeignKey('adverts', 'users', 'fk_adverts_user_id_1',
     {
       'user_id': 'id'
     },
     {
       onDelete: 'CASCADE',
       onUpdate: 'RESTRICT'
     }, cb)
   };
   

   db-migrate up Error:

   [ERROR] AssertionError [ERR_ASSERTION]: ifError got unwanted exception: ER_PARSE_ERROR: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '[ '`user_id`' ]) REFERENCES `users` ([ '`id`' ]) ON DELETE CASCADE ON UPDATE RES' at line 1
   

   db-migrate up --dry-run output:

   [INFO] dry run
   CREATE TABLE IF NOT EXISTS `migrations` (`id` INTEGER  PRIMARY KEY AUTO_INCREMENT NOT NULL, `name` VARCHAR (255) NOT NULL, `run_on` DATETIME  NOT NULL) ;
   SELECT * FROM `migrations` ORDER BY run_on DESC, name DESC;
   SET AUTOCOMMIT=0;;
   START TRANSACTION;;
   ALTER TABLE `adverts` ADD CONSTRAINT `fk_adverts_user_id_1` FOREIGN KEY ([ '`user_id`' ]) REFERENCES `users` ([ '`id`' ]) ON DELETE CASCADE ON UPDATE RESTRICT;
   INSERT INTO `migrations` (`name`, `run_on`) VALUES (?, ?) [ [ '/20191102071140-alter-adverts-fk', '2019-11-02 18:42:17' ] ]
   [INFO] Processed migration 20191102071140-alter-adverts-fk
   COMMIT;;
   [INFO] Done
   
6. khanisak commented on Nov 26, 2019

   

   khanisak

   on Nov 26, 2019

   More actions

   I'm facing this issue too. Any solution guys? thank you.
7. fredleroy commented on Dec 10, 2019

   

   fredleroy

   on Dec 10, 2019

   More actions

   Same issue here, will use plain sql in the meantime
8. wzrdtales

   closed this as completedin 7053c78on Dec 11, 2019
9. wzrdtales commented on Dec 11, 2019

   

   wzrdtales

   on Dec 11, 2019

   Member

   More actions

   there is a new driver version of mysql 2.0.0. it is major release since all drivers signal incompatibility to versions older than node 8.
10. rob-johansen commented on Feb 8, 2020

    

    rob-johansen

    on Feb 8, 2020

    More actions

    Will this be fixed for postgresql too?
11. fredleroy commented on Apr 30, 2020

    

    fredleroy

    on Apr 30, 2020 via email

    More actions

    Hi For mysql it is. Bumpimg db-migrate mysql plugin (or driver dunno what it’s called) version fixed it for me. No idea about postgres. Regards Le jeu. 30 avr. 2020 à 13:10, StickMan077 <notifications@github.com> a écrit :

    Is this Issue resolved? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#635 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AANLKXKIGYBW2LO7P7HQIHLRPFMEDANCNFSM4IDEAKGQ> .

    -- Frédéric Leroy +33 6 85 84 49 07
12. wzrdtales commented on May 1, 2020

    

    wzrdtales

    on May 1, 2020

    Member

    More actions

    As @fredleroy said. It is fixed, but if you @stenrap doesn't provide us with any details, we wont be able to help. Please post your environment.