Skip to content

Code on npm does not match the code on Github #1

Closed
Closed
Code on npm does not match the code on Github#1

Description

@just-boris
just-boris
opened on Jun 1, 2019

Hello!

NPM release contains the actual implementation of events.once, as expected: https://unpkg.com/events.once@2.0.2/index.js

But this repository code is somewhat different: https://github.com/davidmarkclements/events.on/blob/master/index.js

Perhaps you pushed a wrong branch/commit?

Activity

  1. davidmarkclements commented on Jun 1, 2019

    @davidmarkclements
    davidmarkclements
    on Jun 1, 2019
    Owner
    1. this is events.on you're looking for https://github.com/davidmarkclements/events.once
    2. this isn't published yet - it's just a placeholder until events.on lands in core (events: add EventEmitter.on to async iterate over events nodejs/node#27994 (review)) where it'll be updated to correspond.
  2. davidmarkclements
    closed this as completedon Jun 1, 2019

  3. just-boris commented on Jun 1, 2019

    @just-boris
    just-boris
    on Jun 1, 2019
    Author

    Correct. I have confused two repos somehow. Sorry about that 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions