Skip to content

Commit ffeb011

Browse files
committed
Consider numbers in CaseHelper
CaseHelper.camelCaseToSnakeCase completely ignored numbers before this commit.
1 parent f588006 commit ffeb011

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

‎AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/helper/CaseHelper.java‎

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222

2323
public class CaseHelper {
2424

25-
private static final Pattern pattern = Pattern.compile("([A-Z]|[a-z])[a-z]*");
25+
private static final Pattern pattern = Pattern.compile("([A-Z]|[a-z])[a-z0-9]*");
2626

2727
public static String camelCaseToSnakeCase(String camelCase) {
2828

@@ -61,14 +61,15 @@ public static String camelCaseToUpperSnakeCase(String camelCase) {
6161
}
6262

6363
public static String lowerCaseFirst(String string) {
64-
if (string.length() < 2)
64+
if (string.length() < 2) {
6565
return string.toLowerCase();
66+
}
6667
String first = string.substring(0, 1).toLowerCase();
6768
String end = string.substring(1, string.length());
6869
return first + end;
69-
}
70+
}
7071

71-
public static String camelCaseToUpperSnakeCase(String prefix, String camelCase, String suffix) {
72+
public static String camelCaseToUpperSnakeCase(String prefix, String camelCase, String suffix) {
7273
if (prefix != null && !camelCase.startsWith(prefix)) {
7374
camelCase = prefix + "_" + camelCase;
7475
}

‎AndroidAnnotations/androidannotations/src/test/java/org/androidannotations/helper/CaseHelperTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@
1515
*/
1616
package org.androidannotations.helper;
1717

18-
import junit.framework.Assert;
19-
18+
import org.junit.Assert;
2019
import org.junit.Test;
2120

2221
public class CaseHelperTest {
@@ -31,6 +30,7 @@ public void testCamelCaseToUpperSnakeCaseString() throws Exception {
3130
@Test
3231
public void testCamelCaseToUpperSnakeCaseStringStringString() throws Exception {
3332
Assert.assertEquals("CAMEL_CASE", CaseHelper.camelCaseToUpperSnakeCase(null, "camelCase", null));
33+
Assert.assertEquals("CAMEL2_CASE", CaseHelper.camelCaseToUpperSnakeCase(null, "camel2Case", null));
3434
Assert.assertEquals("PREFIX_CAMEL_CASE", CaseHelper.camelCaseToUpperSnakeCase("prefix", "camelCase", null));
3535
Assert.assertEquals("PREFIX_CAMEL_CASE", CaseHelper.camelCaseToUpperSnakeCase("prefix", "prefixCamelCase", null));
3636
Assert.assertEquals("CAMEL_CASE_SUFFIX", CaseHelper.camelCaseToUpperSnakeCase(null, "camelCase", "suffix"));

0 commit comments

Comments
 (0)