Skip to content

Commit 302097d

Browse files
committed
Fix GitHub review states to have correct values
1 parent d4f8397 commit 302097d

2 files changed

Lines changed: 32 additions & 2 deletions

File tree

‎danger_python/models.py‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,9 +1152,10 @@ class Config:
11521152

11531153
class GitHubReviewState(Enum):
11541154
APPROVED = "APPROVED"
1155-
COMMENT = "COMMENT"
1155+
CHANGES_REQUESTED = "CHANGES_REQUESTED"
1156+
COMMENTED = "COMMENTED"
1157+
DISMISSED = "DISMISSED"
11561158
PENDING = "PENDING"
1157-
REQUEST_CHANGES = "REQUEST_CHANGES"
11581159

11591160

11601161
class GitHubReviewers(BaseModel):

‎tests/test_models.py‎

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import pytest
2+
3+
from danger_python.models import DangerDSLJSONType, GitHubReviewState
4+
5+
6+
def test_github_dsl_handles_correct_review_states():
7+
"""
8+
Test that GitHub DSL handles correct review states.
9+
"""
10+
dsl_json = {
11+
"github": {
12+
"reviews": [
13+
{"state": "APPROVED"},
14+
{"state": "CHANGES_REQUESTED"},
15+
{"state": "COMMENTED"},
16+
{"state": "PENDING"},
17+
{"state": "DISMISSED"},
18+
]
19+
}
20+
}
21+
22+
dsl = DangerDSLJSONType(**dsl_json)
23+
24+
assert len(dsl.github.reviews) == 5
25+
assert dsl.github.reviews[0].state == GitHubReviewState.APPROVED
26+
assert dsl.github.reviews[1].state == GitHubReviewState.CHANGES_REQUESTED
27+
assert dsl.github.reviews[2].state == GitHubReviewState.COMMENTED
28+
assert dsl.github.reviews[3].state == GitHubReviewState.PENDING
29+
assert dsl.github.reviews[4].state == GitHubReviewState.DISMISSED

0 commit comments

Comments
 (0)