Skip to content

Unnecessary IsADirectory guard #190

Description

@dk107dk

Description:

As noted in test_util_cache.py:
def test_get_cache_name_directory_does_not_raise(self):
# os.path.getmtime() succeeds on directories too, so the
# IsADirectoryError guard in get_cache_name() is not actually hit
# here -- a directory hashes just like a file would.
cache = self._cache()
name = cache.get_cache_name(os.path.join("tests", "util", "test_resources"))
assert name is not None

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    dead codeFurther information is requested

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions