Skip to content

Support composes at-rule #351

Description

@jonathantneal

Problem: Composition and the Cascade

CSS Modules lets us extend classes using the composes declaration. When extending multiple classes, CSS Modules requires multiple composes declarations. Here is an example of what that CSS looks like:

.some-call-to-action {
  composes: link from 'link-styles.module.css';
  composes: button from 'button-styles.module.css';
}

The issue is that this practice of writing multiple composes declarations defies CSS Cascade (the "C" in "CSS"). Therefore, using multiple composes declarations becomes a non-preferable practice.

Only CSS declarations, that is property/value pairs, participate in the cascade.
— https://developer.mozilla.org/en-US/docs/Web/CSS/Cascade

In CSS, properties overwrite each other, and they do not combine with each other. Here is an example of the cascade:

/* global.css (earlier in order) */

li {
  margin-left: 10px;
}
/* project.css (later in order) */

li {
  margin-left: 0; /* This is a reset of `margin-left` */
}

Note: That example is used in MDN’s introduction to the CSS Cascade.

Authors may also rely on this cascade to manage browser fallbacks (e.g. .layout { display: block; display: grid }).

Even the singular example from this project’s documentation of composition relies on this expectation.

Solution: Composition At-Rule

Please consider supporting a @composes at-rule, which would be functionally identical to the current composes declaration. This would allow authors to utilize composition while still respecting the expectations inherit to CSS.

Here is an example of what that CSS would looks like, mirroring the opening example:

.some-call-to-action {
  @composes link from 'link-styles.module.css';
  @composes button from 'button-styles.module.css';
}

Additional unintentional benefits include:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions