Skip to content

Commit fc44578

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "add tests for identity v3 domain"
2 parents 19b8605 + 2dc060c commit fc44578

3 files changed

Lines changed: 423 additions & 5 deletions

File tree

‎openstackclient/identity/v3/domain.py‎

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -135,13 +135,12 @@ def get_parser(self, prog_name):
135135
'--enable',
136136
dest='enabled',
137137
action='store_true',
138-
default=True,
139138
help='Enable domain (default)',
140139
)
141140
enable_group.add_argument(
142141
'--disable',
143-
dest='enabled',
144-
action='store_false',
142+
dest='disabled',
143+
action='store_true',
145144
help='Disable domain',
146145
)
147146
return parser
@@ -156,8 +155,10 @@ def take_action(self, parsed_args):
156155
kwargs['name'] = parsed_args.name
157156
if parsed_args.description:
158157
kwargs['description'] = parsed_args.description
159-
if 'enabled' in parsed_args:
160-
kwargs['enabled'] = parsed_args.enabled
158+
if parsed_args.enabled:
159+
kwargs['enabled'] = True
160+
if parsed_args.disabled:
161+
kwargs['enabled'] = False
161162

162163
if not kwargs:
163164
sys.stdout.write("Domain not updated, no arguments present")

‎openstackclient/tests/identity/v3/fakes.py‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,13 @@
2121

2222
domain_id = 'd1'
2323
domain_name = 'oftheking'
24+
domain_description = 'domain description'
2425

2526
DOMAIN = {
2627
'id': domain_id,
2728
'name': domain_name,
29+
'description': domain_description,
30+
'enabled': True,
2831
}
2932

3033
group_id = 'gr-010'

0 commit comments

Comments
 (0)