Skip to content

Commit 7a8c9a7

Browse files
Jenkinsopenstack-gerrit
authored andcommitted
Merge "add tests for identity v3 endpoint"
2 parents 7f8791a + 99ad9ef commit 7a8c9a7

3 files changed

Lines changed: 602 additions & 5 deletions

File tree

‎openstackclient/identity/v3/endpoint.py‎

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -165,13 +165,12 @@ def get_parser(self, prog_name):
165165
'--enable',
166166
dest='enabled',
167167
action='store_true',
168-
default=True,
169168
help='Enable endpoint',
170169
)
171170
enable_group.add_argument(
172171
'--disable',
173-
dest='enabled',
174-
action='store_false',
172+
dest='disabled',
173+
action='store_true',
175174
help='Disable endpoint',
176175
)
177176
return parser
@@ -183,7 +182,8 @@ def take_action(self, parsed_args):
183182
parsed_args.endpoint)
184183

185184
if (not parsed_args.interface and not parsed_args.url
186-
and not parsed_args.service and not parsed_args.region):
185+
and not parsed_args.service and not parsed_args.region
186+
and not parsed_args.enabled and not parsed_args.disabled):
187187
sys.stdout.write("Endpoint not updated, no arguments present")
188188
return
189189

@@ -192,13 +192,19 @@ def take_action(self, parsed_args):
192192
service = common.find_service(identity_client, parsed_args.service)
193193
service_id = service.id
194194

195+
enabled = None
196+
if parsed_args.enabled:
197+
enabled = True
198+
if parsed_args.disabled:
199+
enabled = False
200+
195201
identity_client.endpoints.update(
196202
endpoint.id,
197203
service=service_id,
198204
url=parsed_args.url,
199205
interface=parsed_args.interface,
200206
region=parsed_args.region,
201-
enabled=parsed_args.enabled
207+
enabled=enabled
202208
)
203209

204210
return

‎openstackclient/tests/identity/v3/fakes.py‎

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -77,6 +77,20 @@
7777
'enabled': True,
7878
}
7979

80+
endpoint_id = 'e-123'
81+
endpoint_url = 'http://127.0.0.1:35357'
82+
endpoint_region = 'RegionOne'
83+
endpoint_interface = 'admin'
84+
85+
ENDPOINT = {
86+
'id': endpoint_id,
87+
'url': endpoint_url,
88+
'region': endpoint_region,
89+
'interface': endpoint_interface,
90+
'service_id': service_id,
91+
'enabled': True,
92+
}
93+
8094
user_id = 'aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa'
8195
user_name = 'paul'
8296
user_description = 'Sir Paul'
@@ -185,6 +199,8 @@ class FakeIdentityv3Client(object):
185199
def __init__(self, **kwargs):
186200
self.domains = mock.Mock()
187201
self.domains.resource_class = fakes.FakeResource(None, {})
202+
self.endpoints = mock.Mock()
203+
self.endpoints.resource_class = fakes.FakeResource(None, {})
188204
self.groups = mock.Mock()
189205
self.groups.resource_class = fakes.FakeResource(None, {})
190206
self.oauth1 = mock.Mock()

0 commit comments

Comments
 (0)