Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: puppetlabs/puppetlabs-java
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: buzzdeee/puppetlabs-java
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 8 files changed
  • 1 contributor

Commits on Oct 10, 2017

  1. OpenBSD doesn't have /etc/environment, therefore there is no 

    need to fiddle with it. The default case statement, "do nothing"
is all fine here.

Facter::Util::Resolution.with_env is long time gone since
Facter > 2.x. That was even longer before introduced by me.
Remove that OpenBSD special case in the java_version fact,
and assume that $PATH is properly set in order to find
the 'java' binary.

Additionally confine the java_default_home and java_libjvm_path
to OpenBSD kernel as well. Add some flesh to the java_default_home
fact to allow it to find the java binary.
    @buzzdeee
    buzzdeee committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    90e2471 View commit details
    Browse the repository at this point in the history

  2. update metadata.json to include OpenBSD support

    @buzzdeee
    buzzdeee committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    0111827 View commit details
    Browse the repository at this point in the history

  3. do not use unportable readlink utility to find the java_default_home, 

    use Ruby in a more portable fashion.

adapt tests as well
    @buzzdeee
    buzzdeee committed Oct 10, 2017
    Configuration menu
    Copy the full SHA
    f1353d4 View commit details
    Browse the repository at this point in the history
Loading