Yesterdays (2019-08-06) merged PRs break validation #812

Activity

1. nellh commented on Aug 6, 2019

   

   nellh

   on Aug 6, 2019

   Member

   More actions

   Looks like Node 10.10.0 is not sufficient due to this change released in 10.11 nodejs/node#22832, can you update to the latest LTS (10.16.1)?

   I'll make a PR to raise the engine requirement to a version which passes the test suite
2. sappelhoff commented on Aug 6, 2019

   

   sappelhoff

   on Aug 6, 2019

   MemberAuthor

   More actions

   That seems to work, thanks.

   However, I get the following warning:

   (node:15492) ExperimentalWarning: The fs.promises API is experimental
3. rwblair

   closed this as completedin #813on Aug 6, 2019
4. nellh commented on Aug 6, 2019

   

   nellh

   on Aug 6, 2019

   Member

   More actions

   @sappelhoff That is expected on Node 10. fs.promises was marked stable in Node 11, you could use Node 12 (soon to be the LTS version) if you want to suppress the warning.

   👍React with 👍1Reacted by Stefan Appelhoff
5. sappelhoff commented on Aug 6, 2019

   

   sappelhoff

   on Aug 6, 2019

   MemberAuthor

   More actions

   Ah alright. :-)

   @nellh if I may depend on your skill once more ... our Windows CLI is still giving issues: log

   Every dataset now gives quick validation errors:

   1: [ERR] Quick validation failed - the general folder structure does not resemble a BIDS dataset. Have you chosen the right folder (with "sub-*/" subfolders)? Check for structural/naming issues and presence of at least one subject. (code: 61 - QUICK_VALIDATION_FAILED)
   

   Although nodejs is properly installed (and runs fine on non-windows OS using the same data):

   node --version
   v10.16.1
   npm --version
   6.9.0
   yarn --version
   1.16.0
   

   Could it be due to these error messages when cloning bids-validator from master and calling yarn? (see beginning of the log linked above)

   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator > jest-environment-jsdom-global@1.2.0" has unmet peer dependency "jest-environment-jsdom@22.x || 23.x || 24.x".
   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator-web > bootstrap@4.3.1" has unmet peer dependency "jquery@1.9.1 - 3".
   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator-web > bootstrap@4.3.1" has unmet peer dependency "popper.js@^1.14.7".
   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator-web > @zeit/next-css > css-loader@1.0.0" has unmet peer dependency "webpack@^4.0.0".
   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator-web > @zeit/next-css > mini-css-extract-plugin@0.4.3" has unmet peer dependency "webpack@^4.4.0".
   warning "workspace-aggregator-64438cff-256a-4b62-80cd-079d0b54a139 > bids-validator-web > @zeit/next-sass > sass-loader@6.0.6" has unmet peer dependency "webpack@^2.0.0 || >= 3.0.0-rc.0 || ^3.0.0".
   
6. nellh commented on Aug 6, 2019

   

   nellh

   on Aug 6, 2019

   Member

   More actions

   Ah alright. :-)

   @nellh if I may depend on your skill once more ... our Windows CLI is still giving issues: log

   Every dataset now gives quick validation errors:

   1: [ERR] Quick validation failed - the general folder structure does not resemble a BIDS dataset. Have you chosen the right folder (with "sub-*/" subfolders)? Check for structural/naming issues and presence of at least one subject. (code: 61 - QUICK_VALIDATION_FAILED)
   

   Quick validation is just after the new readDirs implementation - my guess is this is a platform bug with the changes. I filed #814 and I can check it out today.