Skip to content

Commit 6d7d611

Browse files
committed
Use raw agreement directly and cleanup
1 parent 058cc86 commit 6d7d611

3 files changed

Lines changed: 4 additions & 11 deletions

File tree

‎core/src/main/java/org/bouncycastle/crypto/hpke/DHKEM.java‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@
77
import org.bouncycastle.crypto.AsymmetricCipherKeyPairGenerator;
88
import org.bouncycastle.crypto.CryptoServicesRegistrar;
99
import org.bouncycastle.crypto.RawAgreement;
10-
import org.bouncycastle.crypto.agreement.BasicRawAgreement;
11-
import org.bouncycastle.crypto.agreement.ECDHCBasicAgreement;
1210
import org.bouncycastle.crypto.agreement.ECDHCRawAgreement;
1311
import org.bouncycastle.crypto.agreement.X25519Agreement;
1412
import org.bouncycastle.crypto.agreement.X448Agreement;

‎pg/src/main/java/org/bouncycastle/openpgp/operator/bc/BcPublicKeyDataDecryptorFactory.java‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,7 @@
1717
import org.bouncycastle.crypto.BufferedAsymmetricBlockCipher;
1818
import org.bouncycastle.crypto.InvalidCipherTextException;
1919
import org.bouncycastle.crypto.Wrapper;
20-
import org.bouncycastle.crypto.agreement.BasicRawAgreement;
21-
import org.bouncycastle.crypto.agreement.ECDHBasicAgreement;
20+
import org.bouncycastle.crypto.agreement.ECDHRawAgreement;
2221
import org.bouncycastle.crypto.agreement.X25519Agreement;
2322
import org.bouncycastle.crypto.agreement.X448Agreement;
2423
import org.bouncycastle.crypto.params.AsymmetricKeyParameter;
@@ -362,7 +361,7 @@ public byte[] decrypt(int keyAlgorithm, AsymmetricKeyParameter peerKey)
362361
switch (keyAlgorithm)
363362
{
364363
case PublicKeyAlgorithmTags.ECDH:
365-
return BcUtil.getSecret(new BasicRawAgreement(new ECDHBasicAgreement()), privKey, peerKey);
364+
return BcUtil.getSecret(new ECDHRawAgreement(), privKey, peerKey);
366365

367366
case PublicKeyAlgorithmTags.X25519:
368367
return BcUtil.getSecret(new X25519Agreement(), privKey, peerKey);

‎pgsc/src/main/java/org/bouncycastle/openpgp/smartcard/simulator/SimulatorOpenPGPSmartCard.java‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,25 +9,21 @@
99
import org.bouncycastle.crypto.InvalidCipherTextException;
1010
import org.bouncycastle.crypto.RawAgreement;
1111
import org.bouncycastle.crypto.Signer;
12-
import org.bouncycastle.crypto.agreement.BasicRawAgreement;
13-
import org.bouncycastle.crypto.agreement.ECDHBasicAgreement;
12+
import org.bouncycastle.crypto.agreement.ECDHRawAgreement;
1413
import org.bouncycastle.crypto.agreement.X25519Agreement;
1514
import org.bouncycastle.crypto.agreement.X448Agreement;
1615
import org.bouncycastle.crypto.encodings.PKCS1Encoding;
1716
import org.bouncycastle.crypto.engines.RSABlindedEngine;
1817
import org.bouncycastle.crypto.params.AsymmetricKeyParameter;
1918
import org.bouncycastle.crypto.params.Ed25519PrivateKeyParameters;
2019
import org.bouncycastle.crypto.params.X25519PrivateKeyParameters;
21-
import org.bouncycastle.crypto.params.X25519PublicKeyParameters;
2220
import org.bouncycastle.crypto.params.X448PrivateKeyParameters;
23-
import org.bouncycastle.crypto.params.X448PublicKeyParameters;
2421
import org.bouncycastle.crypto.signers.DSASigner;
2522
import org.bouncycastle.crypto.signers.ECDSASigner;
2623
import org.bouncycastle.crypto.signers.Ed25519Signer;
2724
import org.bouncycastle.crypto.signers.Ed448Signer;
2825
import org.bouncycastle.crypto.signers.StandardDSAEncoding;
2926
import org.bouncycastle.crypto.util.PublicKeyFactory;
30-
import org.bouncycastle.jcajce.provider.asymmetric.edec.BCXDHPublicKey;
3127
import org.bouncycastle.openpgp.PGPException;
3228
import org.bouncycastle.openpgp.PGPPrivateKey;
3329
import org.bouncycastle.openpgp.PGPPublicKey;
@@ -329,7 +325,7 @@ else if (privateKey instanceof X448PrivateKeyParameters)
329325
}
330326
else
331327
{
332-
agreement = new BasicRawAgreement(new ECDHBasicAgreement());
328+
agreement = new ECDHRawAgreement();
333329
}
334330
break;
335331

0 commit comments

Comments
 (0)