Skip to content

Commit e0ee5df

Browse files
author
Pratik Jain (Accenture International Limited)
committed
Merged PR 688713: Convert ESRP Signing to use PME resources
As part of wave4 security item we need to Eliminate access to Codesigning from Corp Tenants, this PR is to use PME resources for esrp signing task. Here is the wiki of esrp signing task https://dev.azure.com/powerbi/Trident/_wiki/wikis/Trident.wiki/87762/Engineering-Systems-Shared-ESRP-Registration **Runs:-** **powerbi-javascript NPM release:-** https://dev.azure.com/powerbi/Embedded/_build/results?buildId=13345984&view=results ---------------------------------------- #### AI description (iteration 1) #### PR Classification Code update to use PME resources for ESRP signing. #### PR Summary This pull request updates the ESRP signing process to utilize PME resources. - `.pipelines/powerbi-javascript-npm-release.yml`: Updated `EsrpRelease` task to use PME resources, including changes to `keyvaultname`, `signcertname`, and `domaintenantid`. Added `npmAuthenticate` task for NPM authentication. <!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot --> Related work items: #1619784
1 parent 9890921 commit e0ee5df

1 file changed

Lines changed: 6 additions & 6 deletions

File tree

‎.pipelines/powerbi-javascript-npm-release.yml‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -109,13 +109,13 @@ extends:
109109
artifactName: 'drop'
110110
targetPath: '$(Pipeline.Workspace)\PublishedNpmArtifact'
111111

112-
- task: EsrpRelease@8
112+
- task: EsrpRelease@9
113113
inputs:
114-
keyvaultname: 'Trident-ESRP'
115-
authcertname: 'Fabric-ESRP-authentication'
116-
signcertname: 'Fabric-ESRP-signing'
117-
connectedservicename: 'Fabric ESRP-Embedded'
114+
ConnectedServiceName: 'Fabric-ESRP-Secure-Embedded'
115+
UseManagedIdentity: true
118116
clientid: 'f351681f-63af-4d0a-80b2-80bc2ec5cbb2'
117+
keyvaultname: 'Fabric-ES-ESRP-PME'
118+
signcertname: 'Fabric-ESRP-Signing-PME'
119119
intent: 'PackageDistribution'
120120
contentType: 'NPM'
121121
contentsource: 'Folder'
@@ -125,7 +125,7 @@ extends:
125125
approvers: 'alonyeshurun@microsoft.com'
126126
serviceendpointurl: 'https://api.esrp.microsoft.com'
127127
mainpublisher: 'ESRPRELPACMAN'
128-
domaintenantid: '72f988bf-86f1-41af-91ab-2d7cd011db47'
128+
domaintenantid: '975f013f-7f24-47e8-a7d3-abc4752bf346'
129129

130130
- stage: Prod_ApprovalToAddLatestTag
131131
displayName: Approval to set the released package as latest

0 commit comments

Comments
 (0)