Repository navigation
Logging with log4m #245
Description
Is your feature request related to a problem? Please describe.
aas_log needs more flexibility, content-awareness, and unified behaviour
Describe the solution you'd like
Rewrite aas_log based on log4m to support:
- log levels with controllable reporting/crash
- reference to calling function, which should be included in the log
- log IDs to track logging specific logs with an option to display only once (local only)
- log object should be included in
aacacheand passed to jobs - log object/information saved/returned by jobs in case of error
Activity
AljenU commentedon Sep 24, 2021
Log4m works with a singleton logging object, it will be interesting to see if and how that can integrate with logging from the workers.
tiborauer commentedon Sep 25, 2021
I see what you mean. The object could be configured centrally and then saved into the aacache (aas_cache_put and aas_cache_get; I am happy to show you), which is passed to the workers. Then the actual worker could set the logfile path to the domain root (aas_getstudypath, aas_getsubjpath, and aas_getsesspath).
AljenU commentedon Nov 12, 2021
The solution suggests to rewrite based on log4m. Although this may help for some of the items, it may make other ones more difficult to achieve. And, there is logging functionality already in aa. Thus, why not try to add these features to aas_log without log4m?
What are the specific problems that each of the items is solving? What workflow is currently not possible because of it? (And if possible to say, does it look like it would be difficult to solve the issue by making changes to aas_log?)
tiborauer commentedon Nov 12, 2021
Ad 1.: I have no objections against extending aas_log; however, I thought using log4m would be an easier solution.
Ad 2.: The current logging solution is not uniform and streamlined. There are already pieces of code (e.g.
aap.gui_controls) andautomaticanalysis/aa_engine/aas_log.m
Lines 28 to 36 in 3cd5aa9
AljenU commentedon Nov 18, 2021
Hm, maybe an easy first implementation, that does not require changing all existing aas_log statements, could be to use the log4m object within aas_log. That would make it more easy to have tracking of what messages have been displayed, and to disable certain warnings / errors temporarily. Setting verbose to -1 is currently very generic, whereas the comments where it is used indicate that it is mainly or a very specific use case.
AljenU commentedon Nov 18, 2021
And, could then probably work on not having to pass aap into aas_log (init logging only once, though when exactly, after that settings are stored in the logging object).