Screenshots not working with RemoteWebDriver and Shutterbug 1.6 #103

Activity

1. glibas

   self-assigned this

   on Mar 25, 2022
2. glibas commented on Mar 25, 2022

   

   glibas

   on Mar 25, 2022

   Member

   More actions

   Hi @therealdjryan cannot reproduce it here. Could you please share example project/code
3. therealdjryan commented on Mar 25, 2022

   

   therealdjryan

   on Mar 25, 2022

   Author

   More actions

   https://github.com/therealdjryan/shutterbug-test
4. glibas commented on Mar 26, 2022

   

   glibas

   on Mar 26, 2022

   Member

   More actions

   Hi @therealdjryan ,
   It works fine with declaring WebDriver as

   WebDriver driver = new RemoteWebDriver(new URL("http://127.0.0.1:4444/wd/hub"), new ChromeOptions());

   It does not work with declaring through builder as in your example

   WebDriver driver = RemoteWebDriver.builder().address("http://127.0.0.1:4444") .addAlternative(new ChromeOptions()).build();

   The reason for that is that CommandExecutor is instantiated by a lambda result in RemoteWebDriverBuilder

   CommandExecutor executor = (CommandExecutor)result.map((res) -> { return this.createExecutor(handler, res); });
   Will have a look how we can workaround that. In the meantime you can avoid using RemoteWebDriverBuilder which is still marked as Beta.
5. therealdjryan commented on Mar 28, 2022

   

   therealdjryan

   on Mar 28, 2022

   Author

   More actions

   Hi @glibas, Thanks for chasing down the workaround. Unfortunately in my environment I need to be able to set the readTimeout to handle a couple sluggish pages. I don't think there's a way to do that without using the builder, or rather using ClientConfig which is set in the builder
6. glibas commented on Mar 31, 2022

   

   glibas

   on Mar 31, 2022

   Member

   More actions

   Hi @therealdjryan ,
   Still looking how to make it work with builder. There are some issues with invoking method using reflection on lambda refs as mentioned above.

   There is a way, however to set your readTimeout without using builder. It's not pretty but works (effectively same what RemoteWebdriver does under the hood but with Custom ClientConfig instead of default one)

   URL remoteAddress = new URL("http://localhost:4444/wd/hub");
   Tracer tracer = OpenTelemetryTracer.getInstance();
   ClientConfig config = ClientConfig.defaultConfig().baseUrl(remoteAddress).readTimeout(Duration.ofSeconds(60));
   CommandExecutor executor = new HttpCommandExecutor(Collections.emptyMap(), config, new TracedHttpClient.Factory(tracer, org.openqa.selenium.remote.http.HttpClient.Factory.createDefault()));
   CommandExecutor executorTraced =  new TracedCommandExecutor(executor, tracer);
   WebDriver webDriver = new RemoteWebDriver(executorTraced, new ChromeOptions());
   
7. therealdjryan commented on Mar 31, 2022

   

   therealdjryan

   on Mar 31, 2022

   Author

   More actions

   @glibas,
   I am perfectly happy with this solution, it works great. Could you update the readme so future generations know the limitation/solution

   Thanks!
   Dennis
8. glibas commented on Mar 31, 2022

   

   glibas

   on Mar 31, 2022

   Member

   More actions

   Hi @therealdjryan ,
   Will add this to Readme unless I can marry it up with the builder.
   Thanks for raising!
   Glib
9. glibas

   closed this as completedon Apr 4, 2022
10. mkousteris

    added a commit that references this issue on Aug 27, 2022

    FIX: issue with screenshot

    ...

    3a98dae