vendor js/css not minified with env-prod command? #844

Activity

1. etimesg commented on Apr 5, 2017

   

   etimesg

   on Apr 5, 2017

   Contributor

   More actions

   Hello Andrew,

   I believe that's expected. AFAIK css-loader doesn't minimize per default and I couldn't find any treatment for that inside the webpack config files. However, you can workaround this limitation by replacing the CSS rule inside webpack.config.vendor.js with:

   { test: /\.css(\?|$)/, use: extractCSS.extract({ use: isDevBuild ? 'css-loader' : 'css-loader?minimize' }) }

   Please be advised that I only had time to test it using the Angular template. Perhaps someone can address whether a PR to support minified vendor.css in production is welcome and if there is a better approach to implement it.

   Best,
   E

   👍React with 👍1Reacted by Andrew Herrick
2. aherrick commented on Apr 5, 2017

   

   aherrick

   on Apr 5, 2017

   Last edited by aherrick

   Author

   More actions

   @etimesg thanks for the response! Still getting my head wrapped around webpack but this modification makes sense.

   I too am interested in any other suggestions or why it wasn't set to be minimized in Prod by default.
3. SteveSandersonMS commented on Apr 7, 2017

   

   SteveSandersonMS

   on Apr 7, 2017

   Member

   More actions

   I think it could be minified in the prod builds. That would be a nice enhancement. A pull request for that would be welcomed :)
4. SteveSandersonMS

   closed this as completedon Apr 7, 2017