Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

TS2.2 doesn't like "@types/whatwg-fetch" #705

Closed

Description

@benaadams

microsoft/TypeScript#4948 (comment) (Sounds like issue with isomorphic-fetch also)

The entry

"@types/whatwg-fetch": "0.0.28",

Needs to be removed from in fex. ReactReduxSpa/package.json

But then domain-task doesn't like it as its a dependency 😞

Breaking-Changes#typescript-22

Activity

  1. benaadams commented on Feb 23, 2017

    @benaadams
    ContributorAuthor

    Or maybe temporally change typescript from major version "typescript": "^2.0.3", to minor version "typescript": "~2.0.3",?

  2. SteveSandersonMS commented on Feb 23, 2017

    @SteveSandersonMS
    Member

    Thanks for reporting this!

    To fix this, I've updated the templates' TS dependencies to 2.2.1+. This meant that the @types/whatwg-fetch package references could be removed, since fetch is now included in the TS standard lib.

    The updated templates will be published as version 0.8.6 shortly.

  3. kuncevic commented on Apr 11, 2017

    @kuncevic

    Had similar story here angular/angular-cli#5692 but figureout the solution by looking here microsoft/TypeScript#4948

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions