HMR duplicating the app root when changing html or scss, working normal when changing ts ONLY #678

Activity

1. stmart76 commented on Feb 15, 2017

   

   stmart76

   on Feb 15, 2017

   More actions

   Also seeing this, did a fresh install just last night.
2. dillenmeister commented on Feb 15, 2017

   

   dillenmeister

   on Feb 15, 2017

   More actions

   Me too. I have the same problem if I change .ts files as well.

   In boot-client.ts I added some code to remove the element and it seems to work but is not the correct solution to the problem...

   if (module['hot']) {
       module['hot'].accept();
       module['hot'].dispose(() => {
           // Before restarting the app, we create a new root element and dispose the old one
           const oldRootElem = document.querySelector(rootElemTagName);
           const newRootElem = document.createElement(rootElemTagName);
           oldRootElem.parentNode.insertBefore(newRootElem, oldRootElem);
           platform.destroy(); // This doesn't seem to remove the <app> element. I assume is should?
           oldRootElem.parentNode.removeChild(oldRootElem); // Adding this line of code kind of works
       });
   } else {
       enableProdMode();
   }
3. dillenmeister commented on Feb 15, 2017

   

   dillenmeister

   on Feb 15, 2017

   Last edited by dillenmeister

   More actions

   HMR works correctly with Angular 2.4.7 but not with Angular 2.0.2. See this commit
4. stevetayloruk commented on Feb 18, 2017

   

   stevetayloruk

   on Feb 18, 2017

   More actions

   Please see: #665
5. btmadison commented on Feb 18, 2017

   

   btmadison

   on Feb 18, 2017

   Author

   More actions

   I have resolved my issue by changing the code to the following:

   const oldRootElem = document.querySelector(rootElemTagName);
   const newRootElem = oldRootElem.cloneNode(false);
   oldRootElem.parentNode.insertBefore(newRootElem, oldRootElem);

   // tslint:disable-next-line:no-use-before-declare
   platform.destroy();

   instead of createElement, by changing it to clongNode(false) it retains the custom property attributes injected into the index.html. If you are not doing any custom app properties then this is unnecessary.
6. btmadison

   closed this as completedon Feb 18, 2017