This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Repository navigation
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Angular 2 "MusicStore" sample still uses old version of Angular #622
Description
I am learning from the sample project MusicStore for angular 2 and alot of the api's and classes are now deprecated in the stable release. Does anyone want to update them?
I'll take a shot at it when I have time. In the meantime it should be noted.
here are some of the classes and so on that are now deprecated:
- ngFormModel
- router.ROUTER_DIRECTIVES
- Control
EDIT: Here is some of the classes that were deprecated: https://www.picnet.com.au/blogs/guido/post/2016/06/30/upgrading-to-angular-2-reactive-forms-rc3-new-forms/
Activity
tonysneed commentedon Jan 29, 2017
+1 ... The aspnet-spa generator is still using DNX.
MarkPieszak commentedon Jan 29, 2017
You want to check out the Templates/Angular2Spa for up to date repos. I can't remember, but the samples are very old, not sure if they're meant to be used (?). Have to ask Steven on that one though.
As for generators you want to npm install -g generator-aspnetcore-spa to get the latest ones.
tonysneed commentedon Jan 29, 2017
@MarkPieszak I just installed generator-aspnetcore-spa and the templates are DNX-based. I looked at project.json in the dev branch, and that's up-to-date. But it looks like the npm package has not been published from dev. /cc @SteveSanderson
SteveSandersonMS commentedon Jan 30, 2017
@AndrewCarre Yes, you're right - the Angular 2 MusicStore sample is still on
2.0.0-beta.15, which is ancient. If you are interested in updating this, that would be great! Like @MarkPieszak mentions, the up-to-date stuff is in the templates. See thetemplates/directory. At some point, if that sample remains badly out-of-date and nobody is ready to update it, we'll most likely just remove it to avoid confusing anyone.@tonysneed That's not correct. I'm not sure what you're looking at, but
generator-aspnetcore-spaproduces projects based on thedotnettooling (and you can choose betweenproject.json(e.g., works with VS2015 or CLI tooling prior to preview3) or.csproj(e.g., works with VS2017 or CLI tooling preview3+) formats. This is completely up-to-date. You might want to check you have the latestgenerator-aspnetcore-spainstalled (current is v0.7.4) and that you're runningyo aspnetcore-spato start it.tonysneed commentedon Jan 30, 2017
@SteveSanderson Yes, my local version is outdated. If I run
npm install -g generator-aspnet-spaI get 0.1.3.I uninstalled, then re-installed, and still got v 0.1.3. Then I ran
npm install -g generator-aspnet-spa@latestand still got v 0.1.3. Lastly, I triednpm install -g generator-aspnet-spa@0.7.4and got:Is this just an NPM issue? I'm getting this same behavior on both Windows 10 and Mac OS.
SteveSandersonMS commentedon Jan 30, 2017
@tonysneed The package name is
generator-aspnetcore-spa, notgenerator-aspnet-spa.I've just updated the NPM registry to mark
generator-aspnet-spaas deprecated, so you should now get a warning if you try to install it.[-]Project samples are out of date[/-][+]Angular 2 "MusicStore" sample still uses old version of Angular[/+]tonysneed commentedon Jan 30, 2017
Ahhh ... that explains it! I figured it had to be something like that. 😊
SteveSandersonMS commentedon May 22, 2017
This sample has been removed in the latest
devbranch because it was ridiculously out-of-date. We probably don't need a newer equivalent to this sample, because theAngularSpatemplate itself is a more convincing application structure and provides good guidance on its own. It's not desirable to have detailed examples of third-party framework usage in this repo - documentation and samples about that should be maintained by the third-party framework teams themselves.