Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Webpack default entry issue: webpackConfig.entry.main.unshift is not a function. #56

Closed

Description

@laskoviymishka

There is a statement inside of webpack dev middleware ts:
webpackConfig.entry['main'].unshift('webpack-hot-middleware/client');

Beside assuming that we have default main entry (which is not really good, but there is already TODO here), this allso assume that entry point is an array. Webpack is allow to you have this entry as a string.
Webpack ng2 starter as example have following config:
entry: { 'polyfills': './src/polyfills.ts', 'vendor': './src/vendor.ts', 'main': './src/main.browser.ts' },
In this scenario you will have error:
webpackConfig.entry.main.unshift is not a function.

Activity

  1. added a commit that references this issue on Apr 29, 2016
    754e32b
  2. added a commit that references this issue on May 2, 2016
    e315bd2
  3. vladoros commented on Jul 5, 2016

    @vladoros

    Has this fix been released?

  4. laskoviymishka commented on Jul 5, 2016

    @laskoviymishka
    ContributorAuthor

    I think so, do you face this issue?

  5. vladoros commented on Jul 5, 2016

    @vladoros

    Yes, I cleaned up node_modules & typings seems like there was an issue with the module I was integrating with (ng2-admin).
    Thanks.

  6. laskoviymishka commented on Jul 6, 2016

    @laskoviymishka
    ContributorAuthor

    Can you please file separate issue with whole stack trace, and your we pack configs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions