Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Update to React 15 #255

Closed
Closed
Update to React 15#255

Description

@geirsagberg
geirsagberg
opened on Aug 12, 2016

aspnet-webpack-react currently uses React 0.14, which leaves data-reactid-attributes all over the output. Updating to v 15 will fix this, and some other issues (https://facebook.github.io/react/blog/2016/04/07/react-v15.html).

Activity

  1. SteveSandersonMS commented on Aug 15, 2016

    @SteveSandersonMS
    SteveSandersonMS
    on Aug 15, 2016
    Member

    Sounds good! Would you be able to submit a pull request?

  2. geirsagberg commented on Aug 15, 2016

    @geirsagberg
    geirsagberg
    on Aug 15, 2016
    ContributorAuthor

    Yup, see #256.

  3. SteveSandersonMS commented on Aug 16, 2016

    @SteveSandersonMS
    SteveSandersonMS
    on Aug 16, 2016
    Member

    Thanks - closing in favour of #256

  4. SteveSandersonMS
    closed this as completedon Aug 16, 2016

  5. geirsagberg commented on Aug 17, 2016

    @geirsagberg
    geirsagberg
    on Aug 17, 2016
    ContributorAuthor

    A quick note; seems the react-id-attributes are still there in React 15 when calling renderToString, as they are needed to connect the client code. Still, updating to React 15 shouldn't have any adverse effects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions